Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EIP-1559 transaction #177

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support EIP-1559 transaction #177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11af4eb
Support EIP-1559 transaction
samuerio Jun 2, 2023
5f4e5be
Fix the incorrect eip number in comment
samuerio Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"argv": "^0.0.2",
"axios": "^0.21.1",
"dotenv": "^8.0.0",
"ethers": "^5.1.4",
"ethers": "^5.4.2",
"hardhat": "^2.2.1",
"solc": "0.5.8",
"ts-node": "^9.1.1",
Expand Down
11 changes: 7 additions & 4 deletions scripts/compile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,13 @@ async function writeFactoryDeployerTransaction(contract: CompilerOutputContract,
const data = arrayFromHexString(deploymentBytecode)

if (!process.env.MNEMONIC) throw Error("MNEMONIC is required")
const signer = ethers.Wallet.fromMnemonic(process.env.MNEMONIC!!)
const signedEncodedTransaction = await signer.signTransaction({
nonce, gasPrice, gasLimit, value, data, chainId
})
const provider = new ethers.providers.JsonRpcProvider(process.env.RPC)
const signer = ethers.Wallet.fromMnemonic(process.env.MNEMONIC!!).connect(provider)
//if the network supports EIP-1155 transaction, use the EIP-1155 transaction type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment seems to mention the incorrect eip number

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your review, it's fixed now.

const tx = await signer.populateTransaction({
nonce, gasPrice, gasLimit, value, data, chainId
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you using EIP-1559 here? You haven't specified the transaction type and you are not using the maxPriorityFeePerGas or maxBaseFeePerGas here, right

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was also confused for a while, but the key here seems to be using the .populateTransaction method that adds all the necessary fields, including EIP-1559 gas fields. So the comment could be better 100%.

Also, possibly we'd need to support multiple transaction types because, like networks only supporting eip-1559 transactions, there are networks that only support legacy ones.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, didn't know the populateTransaction method does that by default

Copy link

@FroghubMan FroghubMan Jun 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function sendTransaction in ethers.js' abstract Signer is as follows:

// Populates all fields in a transaction, signs it and sends it to the network
async sendTransaction(transaction: Deferrable<TransactionRequest>): Promise<TransactionResponse> {
    this._checkProvider("sendTransaction");
    const tx = await this.populateTransaction(transaction);
    const signedTx = await this.signTransaction(tx);
    return await this.provider.sendTransaction(signedTx);
}

Before signing the transaction, it calls the populateTransaction method to fill in the relevant transaction fields, including the identification of the transaction type. If the type field is not provided, it checks whether the current chain supports EIP-1559. If it does, it populates the maxFeePerGas and maxPriorityFeePerGas fields and generates an EIP-1559 transaction. Otherwise, it generates a Legacy Transaction.

The current adaptation is made to align with the default behavior of the ethers.js library in order to support all EVM-compatible chains.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sendTransaction does not work with all clients, and therefore should not be static. The main issue I have with doing any of these integrations is whether or not a joint library should be created to merge both ethers and ethers-quorum together.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for missing my point. There are several methods of doing things to accomplish the goals in mind, and where I really was going with my comment was that the use of: populateTransaction should not be allowed if there are not corresponding calls in the other main clients.

})
const signedEncodedTransaction = await signer.signTransaction(tx)
const signerAddress = await signer.getAddress()
const contractAddress = ethers.utils.getContractAddress({ from: signerAddress, nonce } )

Expand Down
Loading