-
Notifications
You must be signed in to change notification settings - Fork 914
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
18 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,29 +1,29 @@ | ||
diff -druN Safe.sol Safe.sol | ||
--- Safe.sol 2023-05-16 15:08:39 | ||
+++ Safe.sol 2023-05-25 16:23:56 | ||
@@ -76,7 +76,7 @@ | ||
* so we create a Safe with 0 owners and threshold 1. | ||
* This is an unusable Safe, perfect for the singleton | ||
*/ | ||
- threshold = 1; | ||
+ // threshold = 1; MUNGED: remove and add to constructor of the harness | ||
} | ||
|
||
/** | ||
diff -druN base/Executor.sol base/Executor.sol | ||
--- base/Executor.sol 2023-05-16 15:08:39 | ||
+++ base/Executor.sol 2023-05-25 16:23:31 | ||
@@ -25,11 +25,9 @@ | ||
Enum.Operation operation, | ||
--- base/Executor.sol 2023-06-30 15:32:21.392860349 +0200 | ||
+++ base/Executor.sol 2023-06-30 15:37:58.671801994 +0200 | ||
@@ -26,11 +26,8 @@ | ||
uint256 txGas | ||
) internal returns (bool success) { | ||
+ // MUNGED lets just be a bit more optimistic, `execute` does nothing for `DELEGATECALL` and always returns true | ||
if (operation == Enum.Operation.DelegateCall) { | ||
- // solhint-disable-next-line no-inline-assembly | ||
- /// @solidity memory-safe-assembly | ||
- assembly { | ||
- success := delegatecall(txGas, to, add(data, 0x20), mload(data), 0, 0) | ||
- } | ||
+ // MUNGED lets just be a bit more optimistic, `execute` does nothing for `DELEGATECALL` and always returns true | ||
+ return true; | ||
} else { | ||
// solhint-disable-next-line no-inline-assembly | ||
assembly { | ||
/// @solidity memory-safe-assembly | ||
diff -druN Safe.sol Safe.sol | ||
--- Safe.sol 2023-06-30 15:32:21.392860349 +0200 | ||
+++ Safe.sol 2023-06-30 15:37:17.198953773 +0200 | ||
@@ -76,7 +76,7 @@ | ||
* so we create a Safe with 0 owners and threshold 1. | ||
* This is an unusable Safe, perfect for the singleton | ||
*/ | ||
- threshold = 1; | ||
+ // threshold = 1; MUNGED: remove and add to constructor of the harness | ||
} | ||
|
||
/** |