-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.5.0 Release changes #599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP: EIP-1271 fix * Fix lint issue * Fix bytes32 test by signing hash instead of pre-image * EIP-1271: Fix failing test case for 0xExploit * EIP-1271: Comment data param in function call * EIP-1271: Fix lint issue * Remove use of outdated EIP-1271 method specification. * [#391] Add comment in natspec regarding unused data parameter --------- Co-authored-by: Mikhail <[email protected]>
* add setup and rules about modules * fix run script * use solc7.6 for fv * Mark assembly blocks as memory-safe * use solidity 0.8.19 for github action benchmark * Update makefile * fix the harness patch * properties doc skeleton * properties notes * use 10m optimizer runs * Write calldata/return data to the memory allocated via the free memory pointer * memory-safe simulateAndRevert * Update CLA github action to v2.3.0 * add certora workflow * Fix changelog mention of createChainSpecificProxyWithNonce * fix script path * use cvl2 * Remove gasleft in setupModules, add erc4337 compatibility test * Fix typechecking in test files (#573) * verify that guard can only be updated through setGuard * Verify functions that may change the fallback handler address (#566) * Add an invariant for singleton address (#565) * Add an optimistic assumption about DELEGATECALL, update nonce monotonicity rule (#574) * Pump version to 1.4.1 (#579) * Formal verification: native token balance updates (#582) * Add an optimistic assumption about DELEGATECALL, update nonce monotonicity rule * Add a rule for token balance * Add more rules for native token balance transition * Fix addresses for 1.4.1 in changelog (#590) * Fix certora CI action * Formal verification: No message can be signed through the core contract (#583) * Add a rule for no signed messages * Add a rule for no signed messages * fix munged patch --------- Co-authored-by: teryanarmen <[email protected]> Co-authored-by: Uxio Fuentefria <[email protected]> Co-authored-by: Francisco Giordano <[email protected]> Co-authored-by: Richard Meissner <[email protected]> Co-authored-by: Mikhail Mikheev <[email protected]>
mmv08
requested review from
a team,
rmeissner,
Uxio0 and
akshay-ap
and removed request for
a team
June 30, 2023 13:31
Pull Request Test Coverage Report for Build 5423487370
💛 - Coveralls |
Pull Request Test Coverage Report for Build 5726842109
💛 - Coveralls |
mmv08
force-pushed
the
release/v1.5.0
branch
3 times, most recently
from
June 30, 2023 14:53
157b833
to
6610267
Compare
Added a |
rmeissner
approved these changes
Jul 10, 2023
Feature: bytecode size reduction by removing public `getChainId` function, making encodeTransactionData private
Feature: Use `.call` to transfer native token refund
…into release/v1.5.0
* Alternative implmentation for module guard * Fix lint error * Update interfaceId for Guard * d tests * Update guardmanager interface --------- Co-authored-by: Mikhail <[email protected]>
* Add overloaded checkNSignatures * add legacy checknsignatures tests --------- Co-authored-by: Mikhail <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes for the planned 1.5.0 release:
transfer
andsend
#601