Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certora Prover setup and properties for the audit of migration and setup contracts #829

Closed
wants to merge 4 commits into from
Closed

Certora Prover setup and properties for the audit of migration and setup contracts #829

wants to merge 4 commits into from

Conversation

hristo-grigorov
Copy link
Contributor

This PR includes the setup files (.conf files and a mock) and .spec files with properties.
All the rules were verified using the lastest certora-cli (7.14.2).

It covers the audited contracts:
SafeMigration.sol
SafeToL2Migration.sol
SafeToL2Setup.sol

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

1 out of 2 committers have signed the CLA.
✅ @hristo-grigorov
❌ @hristo
hristo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10833197680

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.571%
Totals Coverage Status
Change from base Build 10826162794: 0.0%
Covered Lines: 396
Relevant Lines: 408
💛 - Coveralls

@hristo-grigorov
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Sep 13, 2024
@github-actions
@hristo-grigorov has signed the CLA in #829
b34921e
@remedcu remedcu mentioned this pull request Sep 16, 2024
Merged
remedcu added a commit that referenced this pull request Sep 16, 2024
@remedcu @hristo-grigorov @nlordell
Migration Contract FV (#832)
fddfd14 
Based on #829 

Some extra changes:
- Adding FV to Certora Workflow
- Remove the unused `data` from the `SafeMock`.
- EOF and some capitalization changes
- Parametric argument to some rules

---------

Co-authored-by: Hristo Grigorov <[email protected]>
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
@remedcu
Copy link
Member

remedcu commented Sep 16, 2024

Closing due to #832

@remedcu remedcu closed this Sep 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hristo-grigorov @coveralls @remedcu