Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments in SignatureVerifierMuxer to reflect correct byte ranges for encodeData and payload lengths #873

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update comments in SignatureVerifierMuxer to reflect correct byte ranges for encodeData and payload lengths #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions contracts/handler/extensible/SignatureVerifierMuxer.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,10 @@ abstract contract SignatureVerifierMuxer is ExtensibleBase, ERC1271, ISignatureV
// 0x00 - 0x04: selector
// 0x04 - 0x36: domainSeparator
// 0x36 - 0x68: typeHash
// 0x68 - 0x6C: encodeData length
// 0x6C - 0x6C + encodeData length: encodeData
// 0x6C + encodeData length - 0x6C + encodeData length + 0x20: payload length
// 0x6C + encodeData length + 0x20 - end: payload
// 0x68 - 0x88: encodeData length
// 0x88 - 0x88 + encodeData length: encodeData
// 0x88 + encodeData length - 0x88 + encodeData length + 0x20: payload length
// 0x88 + encodeData length + 0x20 - end: payload
//
// Get the domainSeparator from the signature.
(bytes32 domainSeparator, bytes32 typeHash) = abi.decode(signature[4:68], (bytes32, bytes32));
Expand Down
Loading