fix: Use NextLink inside Tab component instead of wrapping

safe-global · Dec 19, 2024 · 70a9c29 · 70a9c29
1 parent b786db8
commit 70a9c29
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 22 deletions.
diff --git a/.yarnrc b/.yarnrc
diff --git a/src/components/common/NavTabs/index.tsx b/src/components/common/NavTabs/index.tsx
@@ -13,23 +13,23 @@ const NavTabs = ({ tabs }: { tabs: NavItem[] }) => {
   return (
     <Tabs value={activeTab} variant="scrollable" allowScrollButtonsMobile className={css.tabs}>
       {tabs.map((tab, idx) => (
-        <NextLink key={tab.href} href={{ pathname: tab.href, query }} passHref legacyBehavior>
-          <Tab
-            component="a"
-            tabIndex={0}
-            className={css.tab}
-            label={
-              <Typography
-                variant="body2"
-                fontWeight={700}
-                color={activeTab === idx ? 'primary' : 'primary.light'}
-                className={css.label}
-              >
-                {tab.label}
-              </Typography>
-            }
-          />
-        </NextLink>
+        <Tab
+          key={tab.href}
+          href={{ pathname: tab.href, query }}
+          component={NextLink}
+          tabIndex={0}
+          className={css.tab}
+          label={
+            <Typography
+              variant="body2"
+              fontWeight={700}
+              color={activeTab === idx ? 'primary' : 'primary.light'}
+              className={css.label}
+            >
+              {tab.label}
+            </Typography>
+          }
+        />
       ))}
     </Tabs>
   )