Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: attach safe address to analytics events #2524

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Feat: attach safe address to analytics events #2524

merged 2 commits into from
Sep 20, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Sep 18, 2023

What it solves

Sends safeAddress to GTM

How to test

  • Safe address should be set when opening the app
  • Safe address should be updated when switching safes within the same network
  • Safe address should be updated when switching safes to a different network

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

Branch preview

✅ Deploy successful!

https://gtm_address--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan usame-algan marked this pull request as ready for review September 19, 2023 09:46
@francovenica
Copy link
Contributor

Looks good to me.

The safe address is being tracked
Made sure it tracks only in URL that have the safe address in it. Neutral pages (safe creation, add safe, terms, privacy, etc...) have an empty value ( like this "" )
Switching safes in the same network or different networks tracks the correct safe you are switching into.

image

@katspaugh katspaugh changed the title Attach safe address to GTM Feat: attach safe address to analytics events Sep 20, 2023
@katspaugh katspaugh merged commit 42633fd into dev Sep 20, 2023
@katspaugh katspaugh deleted the gtm-address branch September 20, 2023 06:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants