Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use MultiSendCallOnly 1.3.0 for older Safes #2528

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2498

How this PR fixes it

MultiSendCallOnly only exists as of version 1.3.0. Older Safes (<1.3.0) now use MultiSendCallOnly 1.3.0 by default.

How to test it

Bulk execution

  1. On a <1.3.0 Safe queue multiple transactions.
  2. Click bulk execute from the queue.
  3. Observe no crash.

Simulation

  1. Simulate a multiSend transaction on a <1.3.0 Safe.
  2. Observe no error when simulating (not related to simulation result).

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from schmanu September 19, 2023 17:32
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Branch preview

✅ Deploy successful!

https://minimum_call_only_version--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@francovenica
Copy link
Contributor

Looks good to me

I was able to reproduce the issue in current staging.

I tried the same in a safe 1.1.1 in the PR and the issue doesn't happen anymore
I tried safes 1.3.0 and there no issues there

@katspaugh katspaugh merged commit 426ca2f into dev Sep 26, 2023
9 checks passed
@katspaugh katspaugh deleted the minimum-call-only-version branch September 26, 2023 06:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Invalid MultiSendCallOnly contract address" error
4 participants