Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: strip 0x from safe address when sending to GTM #2530

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Strips 0x from addresses so that they are not interpreted as numbers in GA

Screenshots

Screenshot 2023-09-20 at 10 01 00

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Branch preview

✅ Deploy successful!

https://ga_address_fix--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh changed the title Strip 0x from safe address when sending to GTM Fix: strip 0x from safe address when sending to GTM Sep 20, 2023
@katspaugh katspaugh merged commit 2e062eb into dev Sep 20, 2023
@katspaugh katspaugh deleted the ga-address-fix branch September 20, 2023 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants