fix: notification preferences, post-switch registration + sequential signatures #2551
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves
How this PR fixes it
1. Enable all via banner
The
wallet
is now directly used to create aWeb3Provider
withingetRegisterDevicePayload
. (The chain assertion that happens when clicking "Enable all" causesuseWeb3
to returnundefined
for a short period of time.)2. Confirmation request preference
Ownership of the Safes being registered is no longer references
useIsSafeOwner
. The registrant is inherently registered and the checkbox should therefore be checked. (If they are not an owner or delegate they won't receive notifications, however.)3. Hardware wallet registration
Multiple signatures are now requested sequentially instead of using
Promise.all
.How to test it
1. Enable all via banner
2. Confirmation request preference
3. Hardware wallet registration
Checklist