Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Add Remove owner tests #2587

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Tests: Add Remove owner tests #2587

merged 7 commits into from
Oct 5, 2023

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Oct 4, 2023

What it solves

Resolves #2586

How this PR fixes it

  • Add Remove owner tests: structure, design.
  • Configure to hide unwanted XHR requests in runner

@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://cypress_delete_owner--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@mike10ca mike10ca marked this pull request as ready for review October 5, 2023 10:36
@mike10ca mike10ca requested a review from katspaugh October 5, 2023 10:36
katspaugh
katspaugh approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that spammy messages are now hidden!

@mike10ca mike10ca merged commit 998e8f9 into dev Oct 5, 2023
9 checks passed
@mike10ca mike10ca deleted the cypress-delete-owner branch October 5, 2023 10:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests: Add remove owner tests
2 participants
@mike10ca @katspaugh