Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear awaiting confirmation notifications #2588

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 4, 2023

What it solves

Resolves #2581

How this PR fixes it

  • The txIds of notified awaiting transactions are now cached and referenced.
  • The messageHashes of notified awaiting messages are now cached and referenced.

How to test it

  1. Ensure a Safe with 1+/n is open.
  2. Queue a transaction with owner A.
  3. Switch to owner B.
  4. Observe the awaiting confirmation notification.
  5. Clear all notifications via the centre.
  6. Observe no repeat notification.

Repeat the above, but for off-chain messages.

Screenshots

awaiting confirmation notification

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh October 4, 2023 15:02
@iamacook iamacook self-assigned this Oct 4, 2023
@iamacook iamacook marked this pull request as ready for review October 4, 2023 15:03
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Branch preview

✅ Deploy successful!

https://clear_awaiting_notifications--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Looks good to me

Checked that notifications from pending tx and pending message signing can be dismissed without them showing again.
Checked that the notification pop ups again for new tx or messages.

@iamacook iamacook merged commit 1d6b5d2 into dev Oct 10, 2023
9 checks passed
@iamacook iamacook deleted the clear-awaiting-notifications branch October 10, 2023 13:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications list cannot be fully cleared
3 participants