-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.19.1 #2592
Release 1.19.1 #2592
Conversation
* fix: button height * fix: comment
* fix: nonce field styles * fix: prevent segments from adding option
* Create Sepolia wallets, add more "Add owner" tests, fix flaky cookie acceptance * Fix signing off issue
* Fix: notifications popup: don't hide just one item * Don't wrap txType
* feat: add link to notification settings in centre * fix: pass `query` * fix: remove expansion increase * fix: adjust text + alignment * fix: reduce vertical padding * fix: close centre on navigation
* fix: enable notifications per chain * fix: adjust text * fix: "Safes" -> "Safe Accounts" * fix: remove Safes on unsupported chains
Branch preview✅ Deploy successful! https://release_1_19_1--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Add Remove owner tests. Configure XHR requests in runner. Increase default timeout
There is an issue with the notifications list in the topbar. In this video you can see that I have 4 notifications listed, but there are actually 5. When I create a tx to have the 6th notification I finally see the message " 2 other notifications. |
Small issue with the notification pop up after adding a safe: Add a safe The popUp will open again even when you already enabled notifications in the global settings for it |
I'm having issues with notifications in general, they are not arriving consistently. I want to test this with Aaron since he can see if the user is properly suscribed to the notifications. |
* fix: don't show banner if preferences exist * fix: rename notification feature variables * fix: add tests
The issues I had with notifications are not happening anymore. So notifications are working fine. The tickets that fixed the issues I reported were tested and work fine The tickets in the description are also working fine. If a person with a Mac can check if notifications are working fine there then we are good to go |
* fix: track banner once * fix: rename event * fix: add test
A few fixes for the Push Notifications feature released in v1.19.0.
Bug fixes
Improvements
Tests