Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.19.1 #2592

Merged
merged 22 commits into from
Oct 9, 2023
Merged

Release 1.19.1 #2592

merged 22 commits into from
Oct 9, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Oct 5, 2023

A few fixes for the Push Notifications feature released in v1.19.0.

Bug fixes

Improvements

Tests

bpierre and others added 16 commits September 27, 2023 09:09
* fix: button height

* fix: comment
* fix: nonce field styles

* fix: prevent segments from adding option
* Create Sepolia wallets, add more "Add owner" tests, fix flaky cookie acceptance

* Fix signing off issue
* Fix: notifications popup: don't hide just one item

* Don't wrap txType
* feat: add link to notification settings in centre

* fix: pass `query`

* fix: remove expansion increase

* fix: adjust text + alignment

* fix: reduce vertical padding

* fix: close centre on navigation
* fix: enable notifications per chain

* fix: adjust text

* fix: "Safes" -> "Safe Accounts"

* fix: remove Safes on unsupported chains
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Branch preview

✅ Deploy successful!

https://release_1_19_1--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Add Remove owner tests. Configure XHR requests in runner. Increase default timeout
@francovenica
Copy link
Contributor

There is an issue with the notifications list in the topbar.

In this video you can see that I have 4 notifications listed, but there are actually 5. When I create a tx to have the 6th notification I finally see the message " 2 other notifications.
Maybe is having conflicts with the new " Settings " link?

RC 1

@francovenica
Copy link
Contributor

Small issue with the notification pop up after adding a safe:

Add a safe
See the pop up asking to enable all or customize
Do not dismiss it, ignore it completely and go to the global settings
Enable the safe you just added
Enter in to the safe again

The popUp will open again even when you already enabled notifications in the global settings for it

@francovenica
Copy link
Contributor

I'm having issues with notifications in general, they are not arriving consistently.
With prod CGW I don't get them at all
With Stg CGW I get the first one after suscribing to notifications, but after that they stop.

I want to test this with Aaron since he can see if the user is properly suscribed to the notifications.

katspaugh and others added 2 commits October 6, 2023 13:08
* fix: don't show banner if preferences exist

* fix: rename notification feature variables

* fix: add tests
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
@iamacook iamacook reopened this Oct 6, 2023
@safe-global safe-global unlocked this conversation Oct 6, 2023
@francovenica
Copy link
Contributor

The issues I had with notifications are not happening anymore. So notifications are working fine.
NOTE: they still only work in the Stg CGW

The tickets that fixed the issues I reported were tested and work fine

The tickets in the description are also working fine.

If a person with a Mac can check if notifications are working fine there then we are good to go

iamacook and others added 3 commits October 6, 2023 17:04
* fix: track banner once

* fix: rename event

* fix: add test
)

* Fix: don't show push notifications banner if wallet not conencted; don't track banner dismissal on enable all/customize

* Tests
@katspaugh katspaugh merged commit 854c7be into main Oct 9, 2023
11 checks passed
@katspaugh katspaugh deleted the release/1.19.1 branch October 9, 2023 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants