Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update session after approval #2595

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: update session after approval #2595

merged 2 commits into from
Oct 6, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 5, 2023

What it solves

DApp on wrong chain

How this PR fixes it

  1. The session is now updated after approval with the chain of the Safe, and updated session returned accordingly.
  2. As a precaution, if no active session or matching chainId exists, an error is now returned upon "wrong" request.

How to test it

  1. Connect to Uniswap via native WC with a Safe on Gnosis Chain. Observe it immediately requesting chain switch.
  2. Connect via native WC to a DApp that doesn't support the current Safe and try to transact, observing the "Unsupported chains." error.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh October 5, 2023 14:48
@iamacook iamacook self-assigned this Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Branch preview

✅ Deploy successful!

https://wc_wrong_chain--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook merged commit a4775d1 into nect Oct 6, 2023
@iamacook iamacook deleted the wc-wrong-chain branch October 6, 2023 08:04
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants