Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: console warnings in owner list #2612

Merged
merged 6 commits into from
Oct 12, 2023
Merged

fix: console warnings in owner list #2612

merged 6 commits into from
Oct 12, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 11, 2023

What it solves

Resolves console warnings in owner list.

image

How this PR fixes it

All Tooltip children within the owner list have been wrapped in span elements.

How to test it

Open the project locally and navigate to the owner list within the settings:

  • Observe working tooltips for replacing, editing and removing owners.
  • When clicking each, observe the transaction flow opening as well as correct tracking.

Screenshots

274208285-754faf72-dea9-4bbd-9796-d6ed3d6ce0a0

connected-tooltips

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from usame-algan October 11, 2023 09:03
@iamacook iamacook self-assigned this Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Branch preview

✅ Deploy successful!

https://owner_list_warnings--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

Issue:

When the user is not connected or connected with a non-owner the 2 tooltips can be seen when you hover the icon: the one that ask you to connect/connect with an owner and the one corresponding the icon (replace owner/remove owner)
image

@iamacook
Copy link
Member Author

When the user is not connected or connected with a non-owner the 2 tooltips can be seen when you hover the icon: the one that ask you to connect/connect with an owner and the one corresponding the icon (replace owner/remove owner)

This should now be fixed. If no wallet is connected, replace/remove owner tooltips should request connection before showing:

connected-tooltips

@francovenica
Copy link
Contributor

Looks good now. Thanks

@iamacook iamacook merged commit f263f3d into dev Oct 12, 2023
@iamacook iamacook deleted the owner-list-warnings branch October 12, 2023 17:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants