-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable 1-click safe create for social login #2620
Conversation
Branch preview✅ Deploy successful! https://quick_safe_create--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to adjust the MPCLogin.test.tsx
. You need to mock the currentChain to be on Gnosis Chain such that the buttons are enabled.
You could also add a test case for non supported networks to check that the button is disabled and the hint is shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 small nits in the test. Otherwise LGTM!
Co-authored-by: Manuel Gellfart <[email protected]>
What it solves
Resolves #2458
How this PR fixes it
ToDos
How to test it
Screenshots
Checklist