Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seedless-Onboarding] Add tracking #2626

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Oct 12, 2023

What it solves

Tracking for the MPC Wallet

How this PR fixes it

Adds tracking for the following events:

  • Continue to creation button with connected Wallet
  • Continue with Google button
  • Account recovery started
  • Recover account using password
  • Set or change password
  • Enable MFA for account

How to test it

Test those various events.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from usame-algan October 12, 2023 16:22
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Branch preview

✅ Deploy successful!

https://seedless_tracking--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu requested a review from usame-algan October 17, 2023 15:26
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.66% (+0.07% 🔼)
9291/12445
🔴 Branches
48.73% (-0.01% 🔻)
1864/3825
🔴 Functions
56.49% (+0.11% 🔼)
1366/2418
🟡 Lines
76.21% (+0.05% 🔼)
8397/11018
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / mpcWallet.ts
100% 100% 100% 100%
🟢
... / useTxTracking.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / useMPCWallet.ts
88.06% (+0.56% 🔼)
82.35% (-1.86% 🔻)
75%
87.88% (+0.58% 🔼)

Test suite run success

991 tests passing in 140 suites.

Report generated by 🧪jest coverage report action from 1f45573

@katspaugh
Copy link
Member

IMHO the wallet type should be a user-level property, not event level. Please reseatch how to do this with GTM.

@schmanu schmanu merged commit df74f4e into web3authcoresdk Oct 18, 2023
@schmanu schmanu deleted the seedless-tracking branch October 18, 2023 16:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants