-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Safe App share URL not always working #2830
Conversation
Branch preview✅ Deploy successful! |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Test suite run success1095 tests passing in 154 suites. Report generated by 🧪jest coverage report action from ad10b3a |
I opened a bunch of apps using the share link in different networks and I didn't see the issue and worked fine. I'll recheck in prod once deployed to check that the infinite loader doesn't happen |
To clarify, I meant that the current behavior on prod for unknown/bogus chains is to redirect to the index page. |
What it solves
Safe Apps share URL sometimes redirected to the home page due to a "race condition" when trying to read the chain from the URL.
I've removed the unnecessary chain-detecting logic and the redirect, relying on our existing
useCurrentChain
hook instead.Caveat: if the wrong/non-supported chain is pasted in the URL (e.g. avax while on dev), it will result in an infinite loader. On prod, it would result in a redirect, which isn't much user-friendlier anyway.
How to test
The original bug happened randomly, so it's hard to reproduce. It's sufficient to test that share links still generally work.