Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recovery module removal #2848

Merged
merged 2 commits into from
Nov 22, 2023
Merged

feat: recovery module removal #2848

merged 2 commits into from
Nov 22, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2762

How this PR fixes it

This adds a new recovery module removal flow, guarded by a confirmation modal as per the designs. The flow/modal is also shown if removing a Delay Modifier via the module settings.

How to test it

With recovery enabled, click the remove button from either the "Recovery" or "Modules" section of the settings. Observe the new dialog that, after confirming, allows for successful removal of the recovery module.

Screenshots

remove-recovery

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh November 22, 2023 13:57
@iamacook iamacook linked an issue Nov 22, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Nov 22, 2023

Branch preview

⏳ Deploying a preview site...

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.45% (-0.07% 🔻)
10513/13934
🔴 Branches
50.36% (-0.06% 🔻)
2148/4265
🔴 Functions
58.2% (-0.31% 🔻)
1580/2715
🟡 Lines
76.96% (-0.09% 🔻)
9512/12359
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / ConfirmRemoveRecoveryModal.tsx
50% 100% 0% 50%
🔴
... / index.tsx
55.56% 0% 0% 55.56%
🟡
... / RemoveRecoveryFlowOverview.tsx
66.67% 100% 0% 66.67%
🔴
... / RemoveRecoveryFlowReview.tsx
46.15% 100% 0% 46.15%
🟡
... / index.tsx
66.67% 0% 0% 66.67%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
90% (-10% 🔻)
71.43% (-28.57% 🔻)
75% (-25% 🔻)
89.29% (-10.71% 🔻)

Test suite run success

1194 tests passing in 168 suites.

Report generated by 🧪jest coverage report action from 8919c56

@iamacook iamacook merged commit 2a3fcc9 into recovery-epic Nov 22, 2023
1 of 10 checks passed
@iamacook iamacook deleted the recover-remove branch November 22, 2023 17:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recovery] Remove module flow
2 participants