Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recovery email settings structure #2852

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

iamacook
Copy link
Member

What it solves

Partially resolves #2757

How this PR fixes it

This implements a basic setting structure and modal for adding a recovery email.

How to test it

Open the "Notifications" setting and observe the new template structure, as well as modal that opens when clicking "Add email address".

Screenshots

image

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from katspaugh November 22, 2023 22:46
@iamacook iamacook linked an issue Nov 22, 2023 that may be closed by this pull request
6 tasks
Copy link

github-actions bot commented Nov 22, 2023

Branch preview

✅ Deploy successful!

https://recovery_email_settings--walletweb.review-wallet-web.5afe.dev

Copy link

github-actions bot commented Nov 22, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Nov 22, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.38% (+0.02% 🔼)
10662/14145
🔴 Branches
50.25% (+0.02% 🔼)
2168/4314
🔴 Functions
58.15% (+0.04% 🔼)
1599/2750
🟡 Lines
76.86% (+0.02% 🔼)
9657/12564

Test suite run success

1213 tests passing in 171 suites.

Report generated by 🧪jest coverage report action from 70d2b4d

@iamacook iamacook merged commit 15f0821 into recovery-epic Nov 23, 2023
6 of 11 checks passed
@iamacook iamacook deleted the recovery-email-settings branch November 23, 2023 07:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recovery] Email management
2 participants