Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: add extra tests to address bug fix and restore a deleted test #3173

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

mike10ca
Copy link
Contributor

What it solves

Resolves #3172

How this PR fixes it

As part of our continuous automation tests coverage, the following test were added:

  1. As part of this PR, part of a test was deleted, see comments in the PR. This task fixes it.
  2. A new test covering the fix for the bug.

How to test it

Run Cypress tests and observe the outcome.

Copy link

github-actions bot commented Jan 30, 2024

Copy link

github-actions bot commented Jan 30, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Jan 30, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Jan 30, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.82% 11285/14317
🔴 Branches 56.64% 2507/4426
🟡 Functions 63.08% 1796/2847
🟢 Lines 80.18% 10178/12694

Test suite run success

1384 tests passing in 186 suites.

Report generated by 🧪jest coverage report action from 90dba24

Copy link
Member

@liliya-soroka liliya-soroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@mike10ca mike10ca marked this pull request as ready for review January 30, 2024 12:46
@mike10ca mike10ca merged commit 7d8574d into dev Jan 30, 2024
15 checks passed
@mike10ca mike10ca deleted the extra-cy-tests branch January 30, 2024 12:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add extra Cypress tests
2 participants