Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only show recovery expiry if its not null #3174

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Resolves https://www.notion.so/safe-global/Recovery-tx-1970-as-expires-date-for-never-expires-3e0fab8db7f94ef9bdfebcdcd9d11151

How this PR fixes it

Checks if expiresAt exists before rendering it

How to test it

  1. Open a Safe with recovery where recovery attempts have no expiry
  2. Propose a recovery
  3. Go to the queue
  4. Expand details
  5. Observe expiry is not shown

Screenshots

Screenshot 2024-01-30 at 14 37 52

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from compojoom January 30, 2024 13:37
Copy link

github-actions bot commented Jan 30, 2024

Copy link

github-actions bot commented Jan 30, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Jan 30, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1.03 MB (-1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.82% 11285/14317
🔴 Branches 56.64% 2507/4426
🟡 Functions 63.08% 1796/2847
🟢 Lines 80.18% 10178/12694

Test suite run success

1384 tests passing in 186 suites.

Report generated by 🧪jest coverage report action from e369179

@compojoom compojoom merged commit 137ca47 into dev Jan 30, 2024
15 checks passed
@compojoom compojoom deleted the fix-expiresAt branch January 30, 2024 14:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants