Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add query param to settings link #3629

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Apr 30, 2024

What it solves

Resolves https://www.notion.so/safe-global/a9aab340d6544cecb2c9be2c654a2c62?v=fe4919f55fb34c82afc07f08552c7967&p=f2a55e3ae651421ba8d673dbc8fcdd4a&pm=s

How this PR fixes it

  • Adds query parameter to settings link

How to test it

  • Receive a blind signing request
  • Click on the settings link
  • When asked to cancel the flow, cancel and witness no more crash

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from katspaugh April 30, 2024 14:33
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1006.3 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.08% (+0% 🔼)
11236/14209
🔴 Branches
58.54% (-0% 🔻)
2659/4542
🟡 Functions 66.09% 1811/2740
🟢 Lines
80.34% (+0% 🔼)
10121/12598
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / SignMessage.tsx
91.18% (+0.27% 🔼)
77.27% (-1.3% 🔻)
69.23%
91.92% (+0.25% 🔼)

Test suite run success

1422 tests passing in 198 suites.

Report generated by 🧪jest coverage report action from e876b19

@francovenica
Copy link
Contributor

LGTM

@katspaugh katspaugh merged commit c3f3d9f into dev Apr 30, 2024
14 checks passed
@katspaugh katspaugh deleted the fix/blind-signing-query-param branch April 30, 2024 18:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants