feat: fetch contract info for contract interactions #3652
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1007.63 KB (🟡 +1.31 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Page Added
The following page was added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load |
|---|---|---|
/swap |
28.04 KB |
1.01 MB |
Thirteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/apps |
50.06 KB (🟡 +3.47 KB) |
1.03 MB |
/apps/custom |
41.68 KB (🟡 +3.47 KB) |
1.02 MB |
/apps/open |
85.26 KB (🟡 +10.14 KB) |
1.07 MB |
/balances |
30.63 KB (🟡 +738 B) |
1.01 MB |
/home |
62.96 KB (🟡 +3.19 KB) |
1.05 MB |
/new-safe/create |
32.39 KB (🟡 +10 B) |
1.02 MB |
/new-safe/load |
18.53 KB (🟡 +10 B) |
1 MB |
/settings/safe-apps |
25.33 KB (🟡 +3.47 KB) |
1.01 MB |
/transactions |
107.54 KB (🟡 +5.89 KB) |
1.09 MB |
/transactions/history |
107.51 KB (🟡 +5.89 KB) |
1.09 MB |
/transactions/messages |
67.3 KB (🟡 +5.89 KB) |
1.05 MB |
/transactions/queue |
62.96 KB (🟡 +5.89 KB) |
1.05 MB |
/transactions/tx |
52.31 KB (🟡 +5.89 KB) |
1.04 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Test suite run success1443 tests passing in 202 suites. Report generated by 🧪jest coverage report action from 1451d19 |
| const NamedAddressInfo = ({ address, name, customAvatar, ...props }: EthHashInfoProps) => { | ||
| const chainId = useChainId() | ||
| const [contract] = useAsync(() => getContract(chainId, address), [address, chainId]) | ||
|
|
||
| return ( | ||
| <EthHashInfo | ||
| address={address} | ||
| name={name || contract?.displayName || contract?.name} | ||
| customAvatar={customAvatar || contract?.logoUri} | ||
| {...props} | ||
| /> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Is this doing the same as the onlyName property we added to EthHashInfo? I couldn't test it since the swap widget is disabled on prod cgw and known names are not available on staging cgw
There was a problem hiding this comment.
It fetches the name from the CGW /contract/{address} endpoint if no name is given.
I realized that we never fetch the contract name when we show the to address in "Interact with" fields of transactions or inside batch transactions.
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
|
||
| const NamedAddressInfo = ({ address, name, customAvatar, ...props }: EthHashInfoProps) => { | ||
| const chainId = useChainId() | ||
| const [contract] = useAsync(() => getContract(chainId, address), [address, chainId]) |
There was a problem hiding this comment.
Seems like this would increase the amount of requests per page quite a lot. Should we do it only if there's no name passed in props maybe?
schmanu
force-pushed
the
feat/swap-fetch-contract-info
branch
from
ee8df09 to
92b17e0
Compare
schmanu
force-pushed
the
feat/swap-fetch-contract-info
branch
from
92b17e0 to
1451d19
Compare
What it solves
Contract interactions where not decoded using known addresses.
How this PR fixes it
toaddress during tx decoding.How to test it
Checklist