Feat: Block custom swap recipients if the are in the ofac block list #3654
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1008.63 KB (🟡 +2.31 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
New Page Added
The following page was added to the bundle from the code in this PR:
| Page | Size (compressed) | First Load |
|---|---|---|
/swap |
28.27 KB |
1.01 MB |
Thirteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/apps |
50.06 KB (🟡 +3.47 KB) |
1.03 MB |
/apps/custom |
41.68 KB (🟡 +3.47 KB) |
1.03 MB |
/apps/open |
85.25 KB (🟡 +10.13 KB) |
1.07 MB |
/balances |
30.64 KB (🟡 +739 B) |
1.01 MB |
/home |
63.37 KB (🟡 +3.6 KB) |
1.05 MB |
/new-safe/create |
32.39 KB (🟡 +10 B) |
1.02 MB |
/new-safe/load |
18.53 KB (🟡 +10 B) |
1 MB |
/settings/safe-apps |
25.33 KB (🟡 +3.47 KB) |
1.01 MB |
/transactions |
107.54 KB (🟡 +5.89 KB) |
1.09 MB |
/transactions/history |
107.51 KB (🟡 +5.89 KB) |
1.09 MB |
/transactions/messages |
67.3 KB (🟡 +5.88 KB) |
1.05 MB |
/transactions/queue |
62.96 KB (🟡 +5.88 KB) |
1.05 MB |
/transactions/tx |
52.31 KB (🟡 +5.89 KB) |
1.04 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Test suite run success1458 tests passing in 203 suites. Report generated by 🧪jest coverage report action from baa7207 |
There was a problem hiding this comment.
since we are reusing the block for "signer address", the message that we display for custom recipient is: "this signer address". Personally I feel like this is not something we have to optimize for good user experience, but on the other hand... a correct error message is a basic right in this world :)
I removed the "signer" part so it just says "This address ..." which sounds more accurate now. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
only update params when changed fix: Move state setters into useEffect, adjust text slightly fix: Always set tradeType
usame-algan
force-pushed
the
block-recipient
branch
from
cb1c12f to
baa7207
Compare
What it solves
Resolves: https://www.notion.so/safe-global/07996126a3c041db90e36e01eb4ce46c?v=03b2eaffc9af4b48b1bf57e50546ac3d&p=a0a641560784420ea65fa72c1e036d74&pm=s
Related: #3615
How this PR fixes it
Checklist