Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide Expired status in tx history #3659

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Resolves Notion issue

How this PR fixes it

  • Checks isQueue before rendering the status label and expiry message
  • Removes the previously added isExpiredSwapInfo check

How to test it

  1. Create and queue a limit swap order
  2. Wait for it to expire
  3. The buttons should become disabled in the queue and the message should be visible
  4. Execute a swap order that can be fulfilled
  5. Wait for the execution time to pass
  6. Observe the status label saying Success in the tx history and no message visible
  7. Execute a limit order that can't be fulfilled
  8. Observe the status label saying Success in the tx history and no message visible

Screenshots

Queue expired:
Screenshot 2024-05-06 at 11 54 50

History expired:
Screenshot 2024-05-06 at 11 55 02

History filled:
Screenshot 2024-05-06 at 11 55 20

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@usame-algan usame-algan requested a review from compojoom May 6, 2024 09:55
Copy link

github-actions bot commented May 6, 2024

Copy link

github-actions bot commented May 6, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 6, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1007.61 KB (🟡 +1.29 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page Size (compressed) First Load
/swap 28.04 KB 1.01 MB

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.06 KB (🟡 +3.47 KB) 1.03 MB
/apps/custom 41.68 KB (🟡 +3.47 KB) 1.02 MB
/apps/open 85.1 KB (🟡 +9.98 KB) 1.07 MB
/balances 30.63 KB (🟡 +738 B) 1.01 MB
/home 62.96 KB (🟡 +3.19 KB) 1.05 MB
/new-safe/create 32.39 KB (🟡 +10 B) 1.02 MB
/new-safe/load 18.53 KB (🟡 +10 B) 1 MB
/settings/safe-apps 25.33 KB (🟡 +3.47 KB) 1.01 MB
/transactions 107.38 KB (🟡 +5.73 KB) 1.09 MB
/transactions/history 107.35 KB (🟡 +5.73 KB) 1.09 MB
/transactions/messages 67.14 KB (🟡 +5.72 KB) 1.05 MB
/transactions/queue 62.8 KB (🟡 +5.72 KB) 1.05 MB
/transactions/tx 52.15 KB (🟡 +5.73 KB) 1.03 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented May 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.89% (+0.01% 🔼)
11461/14527
🔴 Branches
57.74% (+0.05% 🔼)
2693/4664
🟡 Functions
65.83% (+0.02% 🔼)
1832/2783
🟢 Lines
80.22% (+0% 🔼)
10330/12877
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / index.tsx
75.93%
10% (-0.34% 🔻)
66.67% 76.92%

Test suite run success

1441 tests passing in 201 suites.

Report generated by 🧪jest coverage report action from 681bfad

@compojoom compojoom closed this May 6, 2024
@compojoom compojoom force-pushed the fix-swap-expired branch from 681bfad to 4ed007f Compare May 6, 2024 11:54
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
@compojoom compojoom reopened this May 6, 2024
@compojoom compojoom merged commit 250d4d4 into feat-cow-swap May 6, 2024
9 of 23 checks passed
@compojoom compojoom deleted the fix-swap-expired branch May 6, 2024 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants