Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sidebar hooks [SW-647] #4641

Merged
merged 12 commits into from
Dec 13, 2024
Merged

Refactor sidebar hooks [SW-647] #4641

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b166275
fix: Remove cache in useAllOwnedSafes
usame-algan Dec 11, 2024
e0b57b7
fix: Write tests for useAllSafes
usame-algan Dec 11, 2024
54993b2
fix: Add more tests for useAllSafes
usame-algan Dec 11, 2024
af23422
refactor: Extract useAllSafes logic into separate functions
usame-algan Dec 11, 2024
631a6c8
refactor: Extract useHasSafes, remove sorting, iterate over all chains
usame-algan Dec 12, 2024
7578c0a
fix: Write test cases for buildSafeItem and prepareAddresses
usame-algan Dec 12, 2024
5bddb48
fix: Implement tests for _prepareAddresses and _buildSafeItem
usame-algan Dec 12, 2024
e127ecb
fix: Check undeployed safe owners to determine readOnly status
usame-algan Dec 12, 2024
2d05119
fix: Remove condition
usame-algan Dec 12, 2024
3fc0562
fix: Remove isOwnerOfAddedSafe check
usame-algan Dec 13, 2024
d8d7ed8
Merge remote-tracking branch 'origin/dev' into sidebar-refactor
usame-algan Dec 13, 2024
03c8136
Merge remote-tracking branch 'origin/dev' into sidebar-refactor
usame-algan Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/welcome/WelcomeLogin/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useRouter } from 'next/router'
import { CREATE_SAFE_EVENTS } from '@/services/analytics/events/createLoadSafe'
import { OVERVIEW_EVENTS, OVERVIEW_LABELS, trackEvent } from '@/services/analytics'
import useWallet from '@/hooks/wallets/useWallet'
import { useHasSafes } from '@/features/myAccounts/hooks/useAllSafes'
import useHasSafes from '@/features/myAccounts/hooks/useHasSafes'
import Track from '@/components/common/Track'
import { useCallback, useEffect, useState } from 'react'
import WalletLogin from './WalletLogin'
Expand Down
Loading
Loading