Fix: allow removing counterfactual safes from safe list #4643
Conversation
Branch preview✅ Deploy successful! Storybook: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (safeAddress === address && safeChainId === chainId) { | ||
| await router.push(AppRoutes.welcome.accounts) | ||
| } | ||
| dispatch(removeUndeployedSafe({ chainId, address })) | ||
| dispatch(removeSafe({ chainId, address })) | ||
| dispatch(removeAddressBookEntry({ chainId, address })) | ||
| handleClose() |
There was a problem hiding this comment.
-
Consolidate
useSafeAddressanduseChainIdwithin a custom hook or context if they are frequently used together to avoid code repetition. -
Add error-handling logic to
handleConfirmfor therouter.pushcall to manage possible navigation failures.
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1020.66 KB (🟡 +40 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Show files with reduced coverage 🔻
Test suite run success1675 tests passing in 228 suites. Report generated by 🧪jest coverage report action from 80d1563 |
There was a problem hiding this comment.
Looks good! 👍
I tested the following cases:
- Remove pinned, undeployed safe while open -> Redirects to the accounts page
- Remove unpinned, undeployed safe while open -> Redirects to the accounts page
- Remove pinned, undeployed safe on the accounts page -> Removes it and stays there
- Remove unpinned, undeployed safe on the accounts page -> Removes it and stays there
What it solves
Resolves #4611
How this PR fixes it
undeployedSafesstore as well as from theaddedSafesstore.How to test it
Screenshots
Checklist