Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rank featured Safe Apps first on dashboard #4644

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Dec 12, 2024

What it solves

Resolves inconsistent display of featured Safe Apps on dashboard

How this PR fixes it

We display Safe Apps on the dashboard by ranking (the amount of times an App is opened) and whether they are pinned. This does not take into account whether they are featured.

This updates the ranking of Safe Apps to put any which are featured in the initial position(s). Thereafter are only (ranked|) pinned Apps, and the "Explore" card.

How to test it

Open the dashboard on a network which has featured Safe Apps and observe featured Apps at the beginning of the list on the dashboard.

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

Copy link

github-actions bot commented Dec 12, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 34.85 KB (🟢 -12 B) 1.03 MB
/apps/custom 32.9 KB (🟢 -12 B) 1.03 MB
/apps/open 55.24 KB (🟢 -14 B) 1.05 MB
/home 60.32 KB (🟢 -12 B) 1.06 MB
/settings/safe-apps 19.42 KB (🟢 -16 B) 1.02 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Dec 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.7% (-0.01% 🔻)
14375/19505
🔴 Branches 51.08% 3419/6693
🔴 Functions
56.41% (-0.03% 🔻)
2028/3595
🟡 Lines
75.28% (-0% 🔻)
13046/17331
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / track-app-usage-count.ts
65.79% (-2.63% 🔻)
25%
70% (-10% 🔻)
77.42%

Test suite run success

1675 tests passing in 228 suites.

Report generated by 🧪jest coverage report action from e7e8120

Copy link

@katspaugh
Copy link
Member

I think this kills the whole point of ranking. There are just 5 slots there and they'll be fully taken by featured apps. Where is this product requirement documented?

I would suggest showing featured apps only after pinned/most used apps to fill up the grid when the former aren't enough.

@iamacook
Copy link
Member Author

I think this kills the whole point of ranking. There are just 5 slots there and they'll be fully taken by featured apps. Where is this product requirement documented?

I would suggest showing featured apps only after pinned/most used apps to fill up the grid when the former aren't enough.

For visibility, the following has since been clarified by product:

  1. Feature Safe Apps
  2. Pinned
  3. Explore card

@iamacook iamacook marked this pull request as ready for review December 12, 2024 10:16
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I get it. With both featured and pinned apps ranked, it still makes sense to keep the ranking.

Copy link

1 similar comment
Copy link

@liliya-soroka
Copy link
Member

Verified

@katspaugh katspaugh merged commit d61021d into dev Dec 16, 2024
16 checks passed
@katspaugh katspaugh deleted the featured-dashboard-apps branch December 16, 2024 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants