-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rank featured Safe Apps first on dashboard #4644
Conversation
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1675 tests passing in 228 suites. Report generated by 🧪jest coverage report action from e7e8120 |
I think this kills the whole point of ranking. There are just 5 slots there and they'll be fully taken by featured apps. Where is this product requirement documented? I would suggest showing featured apps only after pinned/most used apps to fill up the grid when the former aren't enough. |
For visibility, the following has since been clarified by product:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I get it. With both featured and pinned apps ranked, it still makes sense to keep the ranking.
1 similar comment
Verified |
What it solves
Resolves inconsistent display of featured Safe Apps on dashboard
How this PR fixes it
We display Safe Apps on the dashboard by ranking (the amount of times an App is opened) and whether they are pinned. This does not take into account whether they are featured.
This updates the ranking of Safe Apps to put any which are featured in the initial position(s). Thereafter are only (ranked|) pinned Apps, and the "Explore" card.
How to test it
Open the dashboard on a network which has featured Safe Apps and observe featured Apps at the beginning of the list on the dashboard.
Screenshots
Checklist