refactor: Split up MyAccounts component #4671
Conversation
Branch preview✅ Deploy successful! Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1017.21 KB (🟡 +743 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Two Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/transactions/messages |
58.41 KB (🟡 +14 B) |
1.05 MB |
/transactions/msg |
54.57 KB (🟡 +13 B) |
1.05 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1721 tests passing in 234 suites. Report generated by 🧪jest coverage report action from 43cee1d |
There was a problem hiding this comment.
@jmealy I remember we talked about how we handle pinned and watchlist safes. In this hook we say watchlist safes are safes that are not pinned and read-only. I think this doesn't work anymore since an unpinned safe that is not owned or undeployed is removed from the list so watchlist === pinned.
There was a problem hiding this comment.
Makes sense! It was a good idea to equate pinned and watchlist/added, having them as two separate concepts was confusing
usame-algan
force-pushed
the
refactor-myaccounts
branch
from
596b102 to
524eb00
Compare
There was a problem hiding this comment.
Makes sense! It was a good idea to equate pinned and watchlist/added, having them as two separate concepts was confusing
| fullWidth | ||
| size="small" | ||
| /> | ||
| <OrderByButton orderBy={orderBy} onOrderByChange={handleOrderByChange} /> |
There was a problem hiding this comment.
Took me a minute to find the OrderByButton component here. To me AccountsFilter, suggests it only contains the search. Could we rename to reflect that it has both search and sort? AccountListFilters or something
| @@ -46,6 +42,15 @@ const useTrackSafesCount = ( | |||
| [safes, watchlistMultiChainSafes], | |||
| ) | |||
|
|
|||
| // TODO: This is computed here and inside PinnedSafes now. Find a way to optimize it | |||
There was a problem hiding this comment.
A small improvement could be to extract the calculations of allSafes and pinnedSafes into helper functions since they are both done twice, but nbd. IMO it's ok as is
What it solves
Part of SW-647
How this PR fixes it
AccountsListtoMyAccountsAccountsListAllSafes,PinnedSafes,FilteredSafescomponents and moves logicAccountsFilterandAccountsHeadercomponents and moves logicAllSafesGroupedtoAllSafeItemsGroupedAllSafeItemsQueueActionsto be a button instead of an a element to resolve react errorToDos
useTrackedSafesCountHow to test it
Checklist