Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the EIP-5792 implementation #3576

Closed
katspaugh opened this issue Apr 18, 2024 · 1 comment · Fixed by #3656
Closed

Update the EIP-5792 implementation #3576

katspaugh opened this issue Apr 18, 2024 · 1 comment · Fixed by #3656
Assignees

Comments

@katspaugh
Copy link
Member

Our implementation of 5792 seems to be outdated, the calls have been renamed in the EIP: https://eips.ethereum.org/EIPS/eip-5792

Requirements

  • Update the RPC method names
  • Check if the params stayed the same or also need to be updated
@liliya-soroka
Copy link
Member

liliya-soroka commented Jun 4, 2024

Verified:

  • connection to the cowswap/uniswap/curve/
  • bridges ( blocked and not blocked)
  • connection on unsupported networks
  • all methods from the Wallet connect test dapp
  • connect/disconnect
  • connect +sign message to OpenSea on Polygon/Ethereum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants