Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update EIP 5792 implementation to match updated standard #3656

Merged
merged 10 commits into from
Jun 10, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented May 3, 2024

What it solves

Resolves #3576

The EIP 5792 standard was changed since our implementation.

How this PR fixes it

Updates our safe-wallet-provider and wallet connect sessions to support the new 5792 standard:

  • wallet_sendCalls
  • wallet_getCallsStatus
  • wallet_showCallsStatus
  • wallet_getCapabilities

Also sets the capabilities as

How to test it

Use the Wallet connect test dapp

Screenshots

Screenshot 2024-05-03 at 18 49 18
Screenshot 2024-05-03 at 18 48 31
Screenshot 2024-05-03 at 18 47 00

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented May 3, 2024

@schmanu schmanu requested a review from katspaugh May 3, 2024 16:57
Copy link

github-actions bot commented May 3, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 3, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.03 KB (🟡 +48 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented May 3, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.49% (+0.01% 🔼)
11314/14233
🔴 Branches
58.6% (+0.1% 🔼)
2713/4630
🟡 Functions
66.72% (+0.05% 🔼)
1826/2737
🟢 Lines
80.87% (+0.01% 🔼)
10203/12616
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.ts
91.92% (-1.18% 🔻)
84.15% (+2.06% 🔼)
95.45% (+0.45% 🔼)
92.86% (-1.33% 🔻)
🟢
... / useSafeWalletProvider.tsx
82.24% (+0.42% 🔼)
60% (-3.16% 🔻)
70.37% (+1.14% 🔼)
84.16% (+0.29% 🔼)

Test suite run success

1440 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 97d8ce7

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the unit tests need to be updated accordingly.

Copy link

github-actions bot commented May 6, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu requested a review from katspaugh May 6, 2024 15:52
@katspaugh katspaugh marked this pull request as ready for review May 6, 2024 17:08
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link

github-actions bot commented May 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented May 8, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@liliya-soroka
Copy link
Member

  1. Issue: 2 connections for the same app
    Steps:
  • Connect Cow app via WC
  • Connect Uniswap via WC
  • disconnect both apps
  • connect Cow swap or Uniswap
    Current result: 2 connections for the same app
Screen.Recording.2024-05-15.at.13.33.28.mov

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@schmanu schmanu merged commit 224d913 into dev Jun 10, 2024
14 checks passed
@schmanu schmanu deleted the feat/eip5792-update branch June 10, 2024 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the EIP-5792 implementation
3 participants