Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.44.0 #4290

Merged
merged 49 commits into from
Oct 2, 2024
Merged

Release 1.44.0 #4290

merged 49 commits into from
Oct 2, 2024

Conversation

compojoom
Copy link
Collaborator

Features

Bug fixes

Refactor

Chore & tests

PooyaRaki and others added 30 commits September 12, 2024 11:52
…4159)

* add timezone parameter to the transaction history endpoint, removes deprecated timezone_offset

* bump safe-gateway-typescript-sdk version

* Update package.json

---------

Co-authored-by: katspaugh <[email protected]>
* feat: experiment with kiln widget

* feat: add stake concent warning

* fix: wrong widget url

* feat: add theme support for staking widget

* fix: use https address

* Decoding + ifram tweaks

* OrderConfirmationView

* Switch the widget to testnet

* Format values

* Fix types

* TokenInfoPair

* Fix hydration errors with legal disclaimer

* New widget URL

* Pass value to getConfirmationView

* Fix double request for confirmation view

* Update Stake icon

* Token info from the API

* Hide method call for staking orders

* Update confirmation view types

* Display rewards in fiat

* Custom icon for deposits

* Tx details

* Fix type

* Fix tests

* Extract formatSeconds

* Status chips

* Reuse StakingOrderConfirmationView

* Flat style in tx details

* Geoblocking

* Feature toggles and geoblocking

* Move twap module warning to swap order view

* Hide queue bar

* New label in sidebar

* Capitalize status labels

* Fix unit test

* Reuse widget disclaimer component

* Adjust type

* Unify status chips

* Keep queue bar on the stake page

* TokenInfoPair -> ConfirmationOrderHeader

* Fix status chip style

* Rm sidebar tooltip

* feat: add decoding for withdraw request

.

* fix: failing tests

---------

Co-authored-by: katspaugh <[email protected]>
Co-authored-by: katspaugh <[email protected]>
* Fix regression tests
* feat: add claim decoding

* fix: stake deposit tx info should display amount

* fix: label for rewards

.

* fix: use kiln’s production widget url

* fix: use test widget url when on a testchain
* Add google events tests
Bumps [semver](https://github.com/npm/node-semver) from 7.6.0 to 7.6.3.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md)
- [Commits](npm/node-semver@v7.6.0...v7.6.3)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fuse.js](https://github.com/krisk/Fuse) from 6.6.2 to 7.0.0.
- [Release notes](https://github.com/krisk/Fuse/releases)
- [Changelog](https://github.com/krisk/Fuse/blob/main/CHANGELOG.md)
- [Commits](krisk/Fuse@v6.6.2...v7.0.0)

---
updated-dependencies:
- dependency-name: fuse.js
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@safe-global/safe-modules-deployments](https://github.com/safe-global/safe-modules-deployments) from 1.2.0 to 2.2.1.
- [Release notes](https://github.com/safe-global/safe-modules-deployments/releases)
- [Commits](safe-global/safe-modules-deployments@v1.2.0...v2.2.1)

---
updated-dependencies:
- dependency-name: "@safe-global/safe-modules-deployments"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [storybook](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/cli) from 8.0.6 to 8.3.0.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.3.0/code/lib/cli)

---
updated-dependencies:
- dependency-name: storybook
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add some general info about Safe Wallet
…up (#4194)

Bumps the npm_and_yarn group with 1 update: [next](https://github.com/vercel/next.js).


Updates `next` from 14.1.1 to 14.2.10
- [Release notes](https://github.com/vercel/next.js/releases)
- [Changelog](https://github.com/vercel/next.js/blob/canary/release.js)
- [Commits](vercel/next.js@v14.1.1...v14.2.10)

---
updated-dependencies:
- dependency-name: next
  dependency-type: direct:production
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: Cleanup pending txs if nonce already executed

* fix: Add another test for txHistorySlice

* chore: Add pendingTx builder
* fix: display last updated version in cookie banner

The cookie banner now shows the last updated version. In addition to this
it is no longer necessary to update the version number inside of the
store slice. We can control it from the frontmatter of the terms.md doc.

Whenever the version gets updated the cookie banner is going to pop up.
…isplay issues (#4186)

* fix: hide active in if stake validation has started

* fix: hide request withdraw status if ready to withdraw

* feat: add help tooltip for withdraw in

* feat: add stake button on assets page

fix: add area-label to stake button
* feat: add ofac blocking for the stake page

* fix: keep ofac query data for 24h

Currently once we do the ofac check the data will be discarded after 60s
(if no active listeners) and whenever we navigate to a page that needs
that data a new call to the rpc is going to be made. With this change
the data will be kept for up to 24h (if no active listener).
* docs: how to update terms.md

* Update docs/update-terms.md

Co-authored-by: katspaugh <[email protected]>

* Update docs/update-terms.md

Co-authored-by: katspaugh <[email protected]>

* Update docs/update-terms.md

Co-authored-by: katspaugh <[email protected]>

---------

Co-authored-by: katspaugh <[email protected]>
Bumps [contributor-assistant/github-action](https://github.com/contributor-assistant/github-action) from 2.5.1 to 2.5.2.
- [Release notes](https://github.com/contributor-assistant/github-action/releases)
- [Commits](contributor-assistant/github-action@v2.5.1...v2.5.2)

---
updated-dependencies:
- dependency-name: contributor-assistant/github-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fake-indexeddb](https://github.com/dumbmatter/fakeIndexedDB) from 4.0.2 to 6.0.0.
- [Release notes](https://github.com/dumbmatter/fakeIndexedDB/releases)
- [Changelog](https://github.com/dumbmatter/fakeIndexedDB/blob/master/CHANGELOG.md)
- [Commits](dumbmatter/fakeIndexedDB@v4.0.2...v6.0.0)

---
updated-dependencies:
- dependency-name: fake-indexeddb
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#4222)

Bumps [@safe-global/safe-deployments](https://github.com/safe-global/safe-deployments) from 1.37.3 to 1.37.8.
- [Release notes](https://github.com/safe-global/safe-deployments/releases)
- [Commits](safe-global/safe-deployments@v1.37.3...v1.37.8)

---
updated-dependencies:
- dependency-name: "@safe-global/safe-deployments"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
katspaugh and others added 18 commits September 23, 2024 15:58
* fix: Add no-unused-vars and await-thenable eslint rules

* fix: CheckWallet test

* fix: Add back ref extraction in AddressBookInput to fix infinite render in TxFilterForm test
* Feat: rm WC/TxB from dashboard - make space for recent Safe Apps

* Rm unused import

* Fix test

* Rm e2e test
* fix: wrong stake statuses

* fix: small UI discrepancies with the figma designs

* fix: change to format duration to milliseconds

* fix: incorrect status displayed

* refactor: validator exit

* chore: update @safe-global/safe-gateway-typescript-sdk
…oup (#4263)

Bumps the npm_and_yarn group with 1 update: [rollup](https://github.com/rollup/rollup).


Updates `rollup` from 2.79.1 to 2.79.2
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.79.1...v2.79.2)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
the fee is returned by the API in decimal format, so we have to
multiply by 100 to get the percentage
* fix: duplicated advanced data

DecodedTx was rendering a decodedData block, which was also rendered by
the Summary component.

Right now I’m hiding the decodedData block in the summary based on a
prop that is passed by the parent component.

This will be refactored and tested over here:
#4091

* Update src/components/tx/DecodedTx/index.tsx

Co-authored-by: Usame Algan <[email protected]>

---------

Co-authored-by: Usame Algan <[email protected]>
* fix: duplicated advanced data

DecodedTx was rendering a decodedData block, which was also rendered by
the Summary component.

Right now I’m hiding the decodedData block in the summary based on a
prop that is passed by the parent component.

This will be refactored and tested over here:
#4091

* Update src/components/tx/DecodedTx/index.tsx

Co-authored-by: Usame Algan <[email protected]>

* fix: too wide label

* fix: update snapshot

---------

Co-authored-by: Usame Algan <[email protected]>
Copy link

github-actions bot commented Sep 30, 2024

Copy link

github-actions bot commented Sep 30, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 954.83 KB (🟢 -6.28 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.01 KB (🟡 +1.61 KB) 1004.83 KB
/apps/custom 41.64 KB (🟡 +1.61 KB) 996.46 KB
/apps/open 54.7 KB (🟡 +1.61 KB) 1009.53 KB
/home 59.72 KB (🟡 +1.61 KB) 1014.55 KB
/settings/notifications 27.03 KB (🟡 +2 B) 981.85 KB
/settings/safe-apps 25.53 KB (🟡 +1.61 KB) 980.35 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Sep 30, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.09% (-0.38% 🔻)
12000/15366
🔴 Branches
58.17% (-0.85% 🔻)
3084/5302
🟡 Functions
65.09% (-0.76% 🔻)
1889/2902
🟡 Lines
79.63% (-0.28% 🔻)
10831/13601
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢 mocks/terms.md.js 75% 100% 100% 100%
🟢
... / useIsSwapFeatureEnabled.ts
100% 50% 100% 100%
🟢
... / stake.ts
75% 100% 100% 100%
🟡
... / index.tsx
70.59% 0% 0% 75%
🟢
... / index.tsx
66.67% 0% 0% 100%
🟢
... / index.tsx
75% 100% 0% 100%
🟢
... / index.tsx
60% 100% 0% 100%
🟢
... / index.tsx
85.71% 0% 0% 100%
🟢
... / Deposit.tsx
78.57% 0% 0% 84.62%
🟢
... / ConfirmationOrderHeader.tsx
75% 0% 0% 85.71%
🟡
... / index.tsx
73.33% 0% 0% 78.57%
🟡
... / index.tsx
66.67% 100% 0% 66.67%
🟢
... / index.tsx
71.43% 0% 0% 83.33%
🟢
... / constants.ts
50% 100% 100% 100%
🟢
... / index.tsx
80% 100% 0% 100%
🟢
... / Withdraw.tsx
83.33% 100% 0% 100%
🟡
... / index.tsx
55.56% 0% 0% 62.5%
🔴
... / index.tsx
42.86% 0% 0% 46.15%
🟢
... / Exit.tsx
77.78% 0% 0% 87.5%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / transaction-guards.ts
69.74% (-6.51% 🔻)
36.92% (-12.01% 🔻)
68.33% (-6.18% 🔻)
71.11% (-7.79% 🔻)
🟡
... / formatters.ts
74.14% (-3.22% 🔻)
57.14% (-4.4% 🔻)
76.92% (-6.41% 🔻)
74.42% (-2.5% 🔻)
🟡
... / cookiesAndTermsSlice.ts
52.38% (-11.26% 🔻)
33.33% (-66.67% 🔻)
20% (-13.33% 🔻)
64.29% (-21.43% 🔻)
🟡
... / extractTxInfo.ts
68.75% (-7.99% 🔻)
37.74% (-7.72% 🔻)
100%
68.09% (-8.11% 🔻)
🟢 src/utils/url.ts
82.35% (-2.83% 🔻)
100%
80% (+5% 🔼)
89.29% (-6.37% 🔻)
🟡
... / useAsync.ts
64.29% (-35.71% 🔻)
90.91% (-9.09% 🔻)
60% (-40% 🔻)
65% (-35% 🔻)
🟡
... / useDraftBatch.ts
62.07% (-0.89% 🔻)
0% (-100% 🔻)
20%
65.38% (-1.28% 🔻)
🟢
... / index.tsx
82.35% (-8.82% 🔻)
66.67% (-16.67% 🔻)
50% (-12.5% 🔻)
83.87% (-9.68% 🔻)
🔴
... / index.ts
11.32% (-0.44% 🔻)
100% 0%
22.22% (-0.85% 🔻)
🟢
... / DataRow.tsx
80% (-3.33% 🔻)
0% (-66.67% 🔻)
100% 100%
🟢
... / index.tsx
100%
72.22% (-2.78% 🔻)
100% 100%
🟢
... / index.tsx
87.5% (+8.09% 🔼)
38.24% (-3.7% 🔻)
50%
86.84% (+8.72% 🔼)
🟢
... / useIsRecoverySupported.ts
100%
50% (-50% 🔻)
100% 100%
🟢
... / index.tsx
87.06% (-0.58% 🔻)
75.56% (+0.56% 🔼)
50%
86.42% (-0.64% 🔻)
🟡
... / CounterfactualForm.tsx
68.18% (-1.82% 🔻)
42.86% 66.67%
68.25% (-1.9% 🔻)
🟢
... / index.tsx
96.88%
68.18% (-2.55% 🔻)
100% 96.77%
🔴
... / index.tsx
56% (-0.52% 🔻)
0% 20%
59.09% (-0.91% 🔻)
🟢
... / tx-tracking.ts
87.88% (-2.44% 🔻)
81.25% (-5.42% 🔻)
100%
87.5% (-2.5% 🔻)
🟡
... / index.tsx
71.15% (-0.54% 🔻)
11.43% (+0.32% 🔼)
66.67%
72% (-0.55% 🔻)
🟢
... / index.tsx
100%
50% (-50% 🔻)
100% 100%
🟡
... / index.tsx
66.67% (-2.08% 🔻)
0% 0%
70.97% (-2.37% 🔻)
🟢
... / index.tsx
75% (-13.89% 🔻)
100% 0% 100%
🟡
... / useTransactionType.tsx
60.87% (-6.57% 🔻)
36.96% (-2.58% 🔻)
100%
61.36% (-6.93% 🔻)
🟡
... / index.tsx
73.97% (-1.37% 🔻)
60.61% (+1.99% 🔼)
40%
73.91% (-1.45% 🔻)

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 437689a

@francovenica
Copy link
Contributor

With bulk execution the tx are not showing the "Pending" status while they are being executed.

Check this comparison between current prod and the RC
Current prod:
image

The RC:
Here the tx is currently executing, but the buttons remain in "Execute"
image

@francovenica
Copy link
Contributor

The fix looks good
image

@compojoom compojoom merged commit 437689a into main Oct 2, 2024
14 of 15 checks passed
@compojoom compojoom deleted the release branch October 2, 2024 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants