Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set pending state for batched transactions #4298

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Resolves RC issue

Fixes a regression introduced in #4158

How this PR fixes it

  • Sets nonce when emitting tx events from the batch execution

How to test it

  1. Queue and sign at least 2 transactions
  2. Bulk execute them
  3. Observe the Execute button changing to a processing state

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Oct 2, 2024

Copy link

github-actions bot commented Oct 2, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 954.83 KB (🟢 -6.28 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 50.01 KB (🟡 +1.61 KB) 1004.83 KB
/apps/custom 41.64 KB (🟡 +1.61 KB) 996.46 KB
/apps/open 54.7 KB (🟡 +1.61 KB) 1009.53 KB
/home 59.72 KB (🟡 +1.61 KB) 1014.55 KB
/settings/notifications 27.03 KB (🟡 +2 B) 981.85 KB
/settings/safe-apps 25.53 KB (🟡 +1.61 KB) 980.35 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Oct 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.1% (+0.01% 🔼)
12001/15366
🔴 Branches
58.19% (+0.02% 🔼)
3085/5302
🟡 Functions 65.09% 1889/2902
🟡 Lines
79.64% (+0.01% 🔼)
10832/13601

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from b0f6b53

Copy link
Contributor

@compojoom compojoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tested it and it works!

@compojoom compojoom merged commit 437689a into release Oct 2, 2024
12 of 16 checks passed
@compojoom compojoom deleted the fix-batch-pending-state branch October 2, 2024 11:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants