Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: same addresses showing same balance #3795

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix: same addresses showing same balance #3795

merged 1 commit into from
Jun 4, 2024

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #3794

How this PR fixes it

chainId wasn't taken into account when looking up Safes in the balances list.

@katspaugh katspaugh requested a review from compojoom June 4, 2024 09:54
Copy link

github-actions bot commented Jun 4, 2024

Copy link

github-actions bot commented Jun 4, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Jun 4, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 950.01 KB (🟡 +2 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Copy link

github-actions bot commented Jun 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 79.47% 11307/14228
🔴 Branches 58.44% 2704/4627
🟡 Functions 66.57% 1820/2734
🟢 Lines 80.85% 10197/12612

Test suite run success

1437 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from 9f26e2b

Copy link
Contributor

@compojoom compojoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muy bueno!

@katspaugh
Copy link
Member Author

I’ve tested it with the Daniel’s safes.

@katspaugh katspaugh merged commit 59b891d into dev Jun 4, 2024
13 of 14 checks passed
@katspaugh katspaugh deleted the fix-balances branch June 4, 2024 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same safe addresses on different chains show same balance
2 participants