Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add regression cf tests #3797

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Tests: Add regression cf tests #3797

merged 1 commit into from
Jun 4, 2024

Conversation

mike10ca
Copy link
Contributor

@mike10ca mike10ca commented Jun 4, 2024

What it solves

How this PR fixes it

To increase automation tests coverage, automation tests were added for regression CF safe suite.

  • Add regression CF tests
  • Update tx history expected test value
  • Fix regression tests

How to test it

  • Run Cypress tests and observe outcome

Copy link

github-actions bot commented Jun 4, 2024

Copy link

github-actions bot commented Jun 4, 2024

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

github-actions bot commented Jun 4, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 950.16 KB (-5 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/balances 29.26 KB (🟡 +41 B) 979.42 KB
/home 57.46 KB (🟡 +56 B) 1007.62 KB
/settings/notifications 28.07 KB (🟡 +21 B) 978.23 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Jun 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.47% (-0% 🔻)
11307/14228
🔴 Branches
58.44% (+0% 🔼)
2704/4627
🟡 Functions 66.57% 1820/2734
🟢 Lines
80.85% (-0% 🔻)
10197/12612
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
95% (-0.24% 🔻)
90.63% (+2.39% 🔼)
50% 100%

Test suite run success

1439 tests passing in 197 suites.

Report generated by 🧪jest coverage report action from dd67c28

@mike10ca mike10ca marked this pull request as ready for review June 4, 2024 15:03
@francovenica francovenica self-requested a review June 4, 2024 15:13
@mike10ca mike10ca merged commit 4b83813 into dev Jun 4, 2024
14 checks passed
@mike10ca mike10ca deleted the add-cf-regression-tests branch June 4, 2024 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants