-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Multichain): add feature flag checks when adding a new network [SW-240] #4288
Conversation
Branch preview⏳ Deploying a preview site... |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1004.54 KB (🟡 +49.72 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Fifteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
511 B (🟢 -24.37 KB) |
1005.04 KB |
/address-book |
26.09 KB (🟡 +5 B) |
1.01 MB |
/apps/open |
54.7 KB (-1 B) |
1.03 MB |
/balances |
30.95 KB (🟡 +14 B) |
1.01 MB |
/balances/nfts |
19.18 KB (-1 B) |
1023.73 KB |
/home |
60.54 KB (🟡 +839 B) |
1.04 MB |
/new-safe/advanced-create |
36.49 KB (🟡 +1.36 KB) |
1.02 MB |
/new-safe/create |
35.75 KB (🟡 +1.36 KB) |
1.02 MB |
/new-safe/load |
16.41 KB (🟡 +10 B) |
1020.96 KB |
/settings/modules |
9.79 KB (🟡 +1 B) |
1014.33 KB |
/settings/notifications |
27.03 KB (-1 B) |
1.01 MB |
/settings/setup |
35.98 KB (🟡 +5 B) |
1.02 MB |
/transactions/tx |
21.07 KB (-2 B) |
1 MB |
/welcome |
6.8 KB (🟢 -1 B) |
1011.34 KB |
/welcome/accounts |
379 B (🟢 -1 B) |
1004.92 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Coverage report
Show files with reduced coverage 🔻
Test suite run success1550 tests passing in 206 suites. Report generated by 🧪jest coverage report action from 3e98ca9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think feature flags should ideally hide the feature completely.
So in this case disabling the new feature should:
- Hide the "Add new network" button in the sidebar
- In the context menu and multichain groups
- Not offer adding networks through the network selector
5372d33
to
e5c02db
Compare
…s selector and network input
What it solves
Resolves: https://www.notion.so/safe-global/Add-feature-toggle-for-adding-networks-10e8180fe57380b4b27df647dae49742
How this PR fixes it
MULTI_CHAIN_SAFE_ADD_NETWORK
.How to test it
Screenshots
Checklist