Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Multichain): do not migrate to L2 if no lib contract is available #4300

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Oct 2, 2024

What it solves

On e.g. Gnosis Chiado no migration libs are deployed. We still tried to migrate from L1 to L2 though.

How this PR fixes it

  • Does not prepend a migration call if the chain does not have the migration contracts deployed.

How to test it

  • Create a L1 1.3.0 Mainnet Safe
  • Add Gnosis Chiado to it
  • Activate and do any tx
  • It should not try to migrate

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Oct 2, 2024

Copy link

Copy link

github-actions bot commented Oct 2, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1004.44 KB (🟡 +43.34 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eighteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -24.37 KB) 1004.94 KB
/address-book 26.09 KB (🟡 +5 B) 1.01 MB
/apps 50.01 KB (🟡 +1.61 KB) 1.03 MB
/apps/custom 41.64 KB (🟡 +1.61 KB) 1.02 MB
/apps/open 54.7 KB (🟡 +1.61 KB) 1.03 MB
/balances 30.95 KB (🟡 +14 B) 1.01 MB
/balances/nfts 19.18 KB (-1 B) 1023.62 KB
/home 60.54 KB (🟡 +2.42 KB) 1.04 MB
/new-safe/advanced-create 36.5 KB (🟡 +1.37 KB) 1.02 MB
/new-safe/create 35.75 KB (🟡 +1.36 KB) 1.02 MB
/new-safe/load 16.41 KB (🟡 +8 B) 1020.85 KB
/settings/modules 9.82 KB (🟡 +38 B) 1014.26 KB
/settings/notifications 27.03 KB (🟡 +1 B) 1.01 MB
/settings/safe-apps 25.53 KB (🟡 +1.61 KB) 1.01 MB
/settings/setup 35.98 KB (🟡 +5 B) 1.02 MB
/transactions/tx 21.07 KB (-2 B) 1 MB
/welcome 6.8 KB (🟢 -1 B) 1011.24 KB
/welcome/accounts 379 B (🟢 -1 B) 1004.81 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Oct 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.96% (+0.03% 🔼)
12357/15850
🔴 Branches
58.32% (+0.08% 🔼)
3232/5542
🟡 Functions
65.2% (+0.02% 🔼)
1943/2980
🟡 Lines
79.46% (+0.02% 🔼)
11151/14034

Test suite run success

1541 tests passing in 205 suites.

Report generated by 🧪jest coverage report action from d1bad45

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failing unit-test

@schmanu schmanu merged commit d7ee967 into epic/multichain-safes Oct 2, 2024
6 of 13 checks passed
@schmanu schmanu deleted the fix/check-migration-contracts branch October 2, 2024 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants