Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Multichain): validate account data #4302

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Oct 2, 2024

What it solves

Validates the safeAccountConfig of counterfactual Safes as well.

How to test it

  • Try to replay a counterfactual Safe that uses a payment or unknown to address.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Oct 2, 2024

Copy link

Copy link

github-actions bot commented Oct 2, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 987.29 KB (🟡 +26.19 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 511 B (🟢 -24.37 KB) 987.79 KB
/address-book 26.09 KB (🟡 +5 B) 1013.38 KB
/apps/open 53.09 KB (-1 B) 1.02 MB
/balances 29.42 KB (🟢 -1.52 KB) 1016.71 KB
/balances/nfts 19.18 KB (-1 B) 1006.47 KB
/home 57.22 KB (🟢 -923 B) 1.02 MB
/new-safe/advanced-create 36.49 KB (🟡 +1.36 KB) 1023.78 KB
/new-safe/create 35.75 KB (🟡 +1.36 KB) 1023.04 KB
/new-safe/load 16.41 KB (🟡 +6 B) 1003.7 KB
/settings/modules 9.82 KB (🟡 +38 B) 997.11 KB
/settings/notifications 27.03 KB (-2 B) 1014.32 KB
/settings/setup 35.98 KB (🟡 +5 B) 1023.27 KB
/transactions/tx 21.07 KB (-2 B) 1008.36 KB
/welcome 6.8 KB (🟢 -1 B) 994.09 KB
/welcome/accounts 379 B (🟢 -1 B) 987.66 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Oct 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
77.96% (+0.01% 🔼)
12364/15860
🔴 Branches
58.26% (+0.02% 🔼)
3233/5549
🟡 Functions
65.19% (+0.01% 🔼)
1944/2982
🟡 Lines
79.46% (+0.01% 🔼)
11158/14042

Test suite run success

1543 tests passing in 205 suites.

Report generated by 🧪jest coverage report action from bff3fbd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope here but I wonder if we need this nested try catch structure inside useSafeCreationData. If there is an error for one of the chains, shouldn't it already propagate to the outer catch where we log the _816 error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to retry it with other chains if a Safe is deployed on other chains already. Gnosis Chain does not work in most cases for instance.

@schmanu schmanu merged commit 150013a into epic/multichain-safes Oct 7, 2024
12 of 13 checks passed
@schmanu schmanu deleted the fix/validate-account-data branch October 7, 2024 06:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants