-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disable transaction buttons until sdk is initialized #4405
base: dev
Are you sure you want to change the base?
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
@mike10ca The e2e tests can be tested in this PR. Lets see if they still fail as often as before. Do we have a list of e2e test where we know this error happens? |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
1014.47 KB (🟡 +73 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Test suite run success1620 tests passing in 217 suites. Report generated by 🧪jest coverage report action from 6c92cb7 |
@usame-algan yes, this was associated with sending out an NFT. I tested it locally few times and it seems to work. Let's merge it and observe the tests further. |
@francovenica I suggest we test the app with different safe versions. Basically we disable a lot of buttons now if the SDK could not be initialized so we need to make sure it still works even with older safe versions where the SDK might not work. |
What it solves
Resolves #4404
This should make our e2e tests more robust
How this PR fixes it
sdk
insideCheckWallet
which will disable all buttons it wraps until the SDK is initializedHow to test it
Checklist