Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ SW-501 ] fix: Update privacy policy #4437

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

usame-algan
Copy link
Member

What it solves

Updating the privacy policy according to this request

How this PR fixes it

  • Adds markdown support for privacy policy

How to test it

  1. Open the privacy page
  2. Observe the updates from the document

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Oct 28, 2024

Copy link

github-actions bot commented Oct 28, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1012.31 KB (🟡 +13 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/privacy 14.02 KB (🟢 -1.85 KB) 1 MB
/terms 559 B (🟡 +15 B) 1012.86 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Oct 28, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.7% (-0.33% 🔻)
13626/18488
🔴 Branches
51.44% (-1.23% 🔻)
3311/6436
🔴 Functions
57.32% (-0.52% 🔻)
1985/3463
🟡 Lines
75.4% (-0.31% 🔻)
12393/16437
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / transaction-guards.ts
69.91% (-6.19% 🔻)
34.52% (-23.81% 🔻)
68.75% (-10.94% 🔻)
70.73% (-7.32% 🔻)
🟡
... / formatters.ts
74.14% (-5.17% 🔻)
57.14%
76.92% (-7.69% 🔻)
74.42% (-4.65% 🔻)
🟡
... / useDraftBatch.ts
62.07% (-3.45% 🔻)
0% 20% 65.38%
🔴
... / index.ts
11.32% (-1.89% 🔻)
100% 0%
22.22% (-3.7% 🔻)
🟢
... / index.tsx
92.86% (-7.14% 🔻)
50% (-25% 🔻)
100% 100%
🟢
... / DataRow.tsx
80% (-20% 🔻)
0% (-100% 🔻)
100% 100%
🟢
... / index.tsx
96.88% (-3.13% 🔻)
68.18% (-20.95% 🔻)
100%
96.77% (-3.23% 🔻)
🔴
... / index.tsx
57.14% (-37.14% 🔻)
9.52% (-66.67% 🔻)
33.33% (-33.33% 🔻)
59.38% (-37.5% 🔻)
🟡
... / SafeTxGasForm.tsx
64%
45.45% (-18.18% 🔻)
16.67% 62.5%
🟢
... / index.tsx
91.67%
78.38% (-2.7% 🔻)
100% 100%
🟡
... / index.tsx
54.55% (-45.45% 🔻)
0% (-66.67% 🔻)
0% (-100% 🔻)
60% (-40% 🔻)
🟢
... / index.tsx
100%
93.33% (-6.67% 🔻)
100% 100%
🟢
... / index.tsx
86.05%
37.14% (-2.86% 🔻)
42.86% 85.37%
🟢
... / TransferActions.tsx
80.43%
73.33% (-13.33% 🔻)
40% 81.4%
🔴
... / useAllSafesGrouped.ts
28.57% (-42.86% 🔻)
0%
0% (-37.5% 🔻)
27.78% (-50% 🔻)
🔴
... / useAllSafes.ts
50%
17.24% (-3.45% 🔻)
37.5% 55.56%
🟢
... / index.tsx
86.81% (-13.19% 🔻)
72.45% (-27.55% 🔻)
42.86% (-57.14% 🔻)
86.21% (-13.79% 🔻)
🟡
... / CounterfactualForm.tsx
68.18%
42.86% (-17.86% 🔻)
66.67% 68.25%
🟢
... / tokenTransferParams.ts
96.3% (-3.7% 🔻)
80%
80% (-20% 🔻)
95.83% (-4.17% 🔻)
🔴
... / index.tsx
50% (-32.14% 🔻)
0% (-12.5% 🔻)
0% (-100% 🔻)
51.85% (-29.63% 🔻)
🟡
... / index.tsx
55.56% (-44.44% 🔻)
0%
0% (-100% 🔻)
62.5% (-37.5% 🔻)
🟡 src/pages/_app.tsx
69.33% (-0.4% 🔻)
42.86% 0%
68.06% (-0.44% 🔻)
🟡
... / index.tsx
60% (-1.9% 🔻)
0% 0%
66.67% (-1.75% 🔻)
🟢
... / BatchTxList.tsx
66.67% (-33.33% 🔻)
100%
0% (-100% 🔻)
80% (-20% 🔻)
🟡
... / BatchTxItem.tsx
58.33% (-20.83% 🔻)
0% (-71.43% 🔻)
0% (-50% 🔻)
60.87% (-17.39% 🔻)
🔴
... / RecoverAccountFlowReview.tsx
46.38% (-0.85% 🔻)
0% 0%
46.38% (-0.85% 🔻)
🟡
... / index.tsx
66.67% (-33.33% 🔻)
0% (-75% 🔻)
0% (-100% 🔻)
66.67% (-33.33% 🔻)

Test suite run success

1577 tests passing in 209 suites.

Report generated by 🧪jest coverage report action from e47b22f

src/pages/privacy.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@compojoom compojoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liliya-soroka
Copy link
Member

The formatting is broken in a new version. Please check why it looks so different and sometimes with the wrong numbering

@usame-algan
Copy link
Member Author

The formatting is broken in a new version. Please check why it looks so different and sometimes with the wrong numbering

Updated the document. The numbering should be fixed. The styles might look a bit different than before but it is more consistent with the styling of the terms page now.

@usame-algan usame-algan mentioned this pull request Nov 7, 2024
3 tasks
@liliya-soroka liliya-soroka changed the title fix: Update privacy policy [ SW-501 ] fix: Update privacy policy Nov 7, 2024
Copy link

@francovenica
Copy link
Contributor

I was able to see that the changes are there, but I don't have access to the doc, so I cannot confirm everythign is correct.

I requested access and I'll wait to have it

@liliya-soroka
Copy link
Member

verified by the product - mhttps://www.notion.so/safe-global/fix-Update-privacy-policy-1378180fe573801a9df1d33eb19d6e4c?pvs=4

@usame-algan usame-algan merged commit f21eab4 into dev Nov 11, 2024
15 checks passed
@usame-algan usame-algan deleted the update-privacy-policy branch November 11, 2024 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants