Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.45.3 #4451

Merged
merged 14 commits into from
Nov 5, 2024
Merged

Release 1.45.3 #4451

merged 14 commits into from
Nov 5, 2024

Conversation

jmealy
Copy link
Contributor

@jmealy jmealy commented Oct 30, 2024 •
edited by compojoom
Loading

Features

Chores and Tests

Bug Fixes

schmanu and others added 12 commits October 24, 2024 10:21
@schmanu
fix: revalidate input when removing networks (#4403)
932e12f
@compojoom
Merge branch 'main' into dev
d8fcd33
@tmjssz
feat: Staking banner (#4396)
ce95e2d 
* feat: Show banner for staking on dashboard

Show a banner for staking on the dashboard if the user holds >= 32 ETH.

* fix: typo in css class names

* fix: memoize native token balance calculation

* feat: add "learn more" link for staking

* feat: add new feature flag specifically for the staking dashboard banner

Remove the swap banner in favor of the the staking banner

* feat: extend StakingBanner by an option to render two different versions (dafault + large)

* large version is rendered on the dashboard
* default version is rendered on the assets page
@compojoom
fix: cypress test fails due to incorrect nonce (#4418)
097a59f
@usame-algan
fix: Remove SAP banner (#4414)
9227a7c 
* fix: Remove swap and SAP banner

* fix: Remove unused events
@dependabot
Chore(deps-dev): Bump @storybook/addon-links from 8.0.6 to 8.3.4 (#4367)
dc8c75f 
Bumps [@storybook/addon-links](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/links) from 8.0.6 to 8.3.4.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v8.3.4/code/addons/links)

---
updated-dependencies:
- dependency-name: "@storybook/addon-links"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tmjssz
fix: Staking banner corrections [SW-380] (#4423)
9620abd 
* refactor: Update StakingBanner link query parameters

Link to the apps page filtered by "staking" category

* fix: banner button size for mobile screen

* refactor: Update StakingBanner component to allow custom hideLocalStorageKey

Use different local storage keys for banner on dashboard. That way, if the "Don't show again" button is clicked, the banner is only hidden on the dashboard, but not on the assets page (and vice versa)

* fix: button width when being hovered
@iamacook
fix: hide suspicious transactions by default (#4425)
1b1f128 
* Hide suspicious transactions by default

* Only default if `undefined`

* Update E2E test

* Fix E2E
@schmanu
test: add unit test for NetworkMultiSelector (#4424)
29b9164
@mike10ca
Tests: Update tests (#4438)
d744ac9
@jmealy
Feat: Targeted survey banner popup [SW-269] (#4338)
e828002 
* feat: add outreach popup

* feat: add close and ask again later funcitonality

* Feat: finish implementing design of outreach popup.

* refactor: extract getUpdatedUserActivity to utils

* fix: mobile popup styles

* fix: do not show at the same time as cookie banner

* fix: fix dark mode styles

* Chore: add tracking to outreach banner

* fix: mock cookie banner state in unit tests

* tests: add unit tests for utils

* fix: update import

* feat: use light theme also in dark mode

* feat: ask again after 24 hours or after current session

* remove unused utils

* feat: only show banner if the safe is targeted for the current outreach and has not already clicked the CTA

* use faker for ethereum addresses in the tests

* fix: cache getSubmission result to avoid multiple requests

* fix: some non targeted safes showing banner
@jmealy
1.45.3
3af2b82
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Branch preview

✅ Deploy successful!

Website:
https://release--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://release--walletweb.review.5afe.dev/storybook/

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 1011.76 KB (🟢 -133 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps 48.42 KB (🟡 +1 B) 1.04 MB
/apps/custom 40.06 KB (🟡 +1 B) 1.03 MB
/apps/open 55.18 KB (🟢 -8 B) 1.04 MB
/balances/nfts 19.2 KB (🟡 +1 B) 1.01 MB
/stake 597 B (🟡 +1 B) 1012.34 KB
/transactions 73.69 KB (🟢 -8 B) 1.06 MB
/transactions/history 73.66 KB (🟢 -8 B) 1.06 MB
/transactions/messages 39.2 KB (🟢 -8 B) 1.03 MB
/transactions/msg 29.53 KB (🟢 -8 B) 1.02 MB
/transactions/queue 31.31 KB (🟢 -8 B) 1.02 MB
/transactions/tx 21.08 KB (🟢 -8 B) 1.01 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
73.59% (-0.12% 🔻)
 13677/18585
🔴 Branches
51.42% (-0.07% 🔻)
 3317/6451
🔴 Functions
57.13% (-0.12% 🔻)
 1987/3478
🟡 Lines
75.3% (-0.1% 🔻)
 12440/16520
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / NetworkMultiSelector.tsx
 98.36% 80.95% 100% 100%
🔴
... / index.tsx
 46.94% 14.29% 16.67% 48.94%
🟡
... / index.tsx
 55.56% 0% 0% 62.5%
🔴
... / useSafeSetupHints.ts
 14.29% 0% 0% 15.38%
🟢
... / useShowOutreachPopup.tsx
 100% 100% 100% 100%
🟢
... / constants.ts
 70% 100% 100% 100%
🔴
... / index.tsx
 40% 0% 0% 41.86%
🟢
... / outreach.ts
 66.67% 100% 100% 100%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡
... / popupSlice.ts
45% (-8.85% 🔻)
 100%
14.29% (-10.71% 🔻)
63.64% (-11.36% 🔻)
🟡
... / index.ts
67.74% (-15.59% 🔻)
 100%
46.15% (-20.51% 🔻)
69.23% (-20.24% 🔻)
🟢
... / useLocalStorage.ts
82.05% (-5.05% 🔻)
 60%
77.78% (-7.94% 🔻)
83.78% (-2.88% 🔻)
🟢
... / useTxHistory.ts
 96.67%
61.11% (-5.56% 🔻)
 100% 96.43%

Test suite run success

1584 tests passing in 210 suites.

Report generated by 🧪jest coverage report action from fd29be1

@jmealy jmealy changed the base branch from dev to main October 30, 2024 13:32
@francovenica
Copy link
Contributor

The Targeted survey banner doesn't show in the Prod CGW. Are we sure it will show in prod once deployed?
It shows fine in the Stg CGW.

The rest looks fine and automation passed as well

@liliya-soroka
Copy link
Member

liliya-soroka commented Nov 4, 2024 •
edited
Loading

4.11

  1. survey banner is displayed after I have passed survey( details - https://5afe.slack.com/archives/C07NN1TBBGU/p1730724041410119?thread_ts=1730719666.386699&cid=C07NN1TBBGU) :
  • open the safe with survey
  • click get involved
  • pass survey
  • come back to the safe
    Current result:
image
  • click X icon
  • check in N minutes
    Current result: The survey will be displayed again if the owner is reconnected
  1. regression run is green

@usame-algan
Copy link
Member

survey banner is displayed after I have passed survey

This issue comes from RTK query caching the result of the submission. We need to disable the cache for the submission query.

@usame-algan
fix: Refetch submission data when submitting submission (#4469)
fd29be1 
* fix: Refetch submission data when submitting submission

* fix: Use mutation for createSubmission and invalidate cache
@francovenica
Copy link
Contributor

francovenica commented Nov 4, 2024 •
edited
Loading

LGTM

I tried both, filling the form and closing with the X in the banner, both time the survey didn't show up again for me.

In the gif I started the survey, disconnected, connected again. Didn't show up.
Finished the survey, closed the tab, reopened it. The banner doesn't show up anymore
transition

Did the same with the "X" (no gif)

Also, as soon as you hit "Get started" the entry is saved in the DB

Note: this was tested in Stg cgw.

@jmealy jmealy merged commit fd29be1 into main Nov 5, 2024
19 of 20 checks passed
@jmealy jmealy deleted the release branch November 5, 2024 12:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@compojoom compojoom compojoom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jmealy @francovenica @liliya-soroka @usame-algan @compojoom @schmanu @tmjssz @iamacook @mike10ca