Require Python 3.9 #154
Merged
Require Python 3.9 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
This was fixed in #146. |
saraedum
commented
Feb 1, 2024
saraedum
commented
Feb 1, 2024
|
Indeed 3.8 is still broken. Let's remove it? |
build with Python 3.8 seems to fail with
```
In file included from /home/conda/feedstock_root/build_artifacts/cypari2_1705557903378/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/python3.8/pytime.h:6,
from /home/conda/feedstock_root/build_artifacts/cypari2_1705557903378/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/python3.8/Python.h:85,
from cypari2/convert.c:50:
cypari2/pycore_long.h: In function '_PyLong_SetSignAndDigitCount':
cypari2/pycore_long.h:92:13: error: 'o' undeclared (first use in this function); did you mean 'op'?
92 | Py_SIZE(o) = size;
|
```
also our CI only tests with Python 3.9+ so that seem to be required by
now.
In any case, active support for Python 3.8 ended May 2021 and security
support is going to end in October 2024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build with Python 3.8 seems to fail with
also our CI only tests with Python 3.9+ so that seem to be required by now.
In any case, active support for Python 3.8 ended May 2021 and security support is going to end in October 2024.