Skip to content

Commit

Permalink
Deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
Matthias Koeppe committed Jun 26, 2024
1 parent 0bdde67 commit a9b2ccf
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 0 deletions.
8 changes: 8 additions & 0 deletions src/sage/schemes/generic/divisor.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,18 @@ def is_Divisor(x):
sage: x,y = AffineSpace(2, GF(5), names='xy').gens()
sage: C = Curve(y^2 - x^9 - x)
sage: is_Divisor(C.divisor([]))
doctest:warning...
DeprecationWarning: The function is_Divisor is deprecated;
use 'isinstance(..., Divisor_generic)' instead.
See https://github.com/sagemath/sage/issues/38277 for details.
True
sage: is_Divisor("Ceci n'est pas un diviseur")
False
"""
from sage.misc.superseded import deprecation
deprecation(38277,
"The function is_Divisor is deprecated; "
"use 'isinstance(..., Divisor_generic)' instead.")
return isinstance(x, Divisor_generic)


Expand Down
8 changes: 8 additions & 0 deletions src/sage/schemes/toric/chow_group.py
Original file line number Diff line number Diff line change
Expand Up @@ -1244,10 +1244,18 @@ def is_ChowCycle(x) -> bool:
sage: A = P2.Chow_group()
sage: from sage.schemes.toric.chow_group import *
sage: is_ChowCycle(A)
doctest:warning...
DeprecationWarning: The function is_ChowCycle is deprecated;
use 'isinstance(..., ChowCycle)' instead.
See https://github.com/sagemath/sage/issues/38277 for details.
False
sage: is_ChowCycle(A.an_element())
True
sage: is_ChowCycle('Victoria')
False
"""
from sage.misc.superseded import deprecation
deprecation(38277,
"The function is_ChowCycle is deprecated; "
"use 'isinstance(..., ChowCycle)' instead.")
return isinstance(x, ChowCycle)
8 changes: 8 additions & 0 deletions src/sage/schemes/toric/divisor.py
Original file line number Diff line number Diff line change
Expand Up @@ -207,13 +207,21 @@ def is_ToricDivisor(x):
sage: from sage.schemes.toric.divisor import is_ToricDivisor
sage: is_ToricDivisor(1)
doctest:warning...
DeprecationWarning: The function is_ToricDivisor is deprecated;
use 'isinstance(..., ToricDivisor_generic)' instead.
See https://github.com/sagemath/sage/issues/38277 for details.
False
sage: P2 = toric_varieties.P2()
sage: D = P2.divisor(0); D
V(x)
sage: is_ToricDivisor(D)
True
"""
from sage.misc.superseded import deprecation
deprecation(38277,
"The function is_ToricDivisor is deprecated; "
"use 'isinstance(..., ToricDivisor_generic)' instead.")
return isinstance(x, ToricDivisor_generic)


Expand Down
8 changes: 8 additions & 0 deletions src/sage/schemes/toric/variety.py
Original file line number Diff line number Diff line change
Expand Up @@ -3305,12 +3305,20 @@ def is_CohomologyClass(x):
sage: HH = P2.cohomology_ring()
sage: from sage.schemes.toric.variety import is_CohomologyClass
sage: is_CohomologyClass( HH.one() ) # needs sage.libs.singular
doctest:warning...
DeprecationWarning: The function is_CohomologyClass is deprecated;
use 'isinstance(..., CohomologyClass)' instead.
See https://github.com/sagemath/sage/issues/38277 for details.
True
sage: is_CohomologyClass( HH(P2.fan(1)[0]) ) # needs sage.libs.singular
True
sage: is_CohomologyClass('z')
False
"""
from sage.misc.superseded import deprecation
deprecation(38277,
"The function is_CohomologyClass is deprecated; "
"use 'isinstance(..., CohomologyClass)' instead.")
return isinstance(x, CohomologyClass)


Expand Down

0 comments on commit a9b2ccf

Please sign in to comment.