-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile everything with meson #36524
base: develop
Are you sure you want to change the base?
Conversation
This reverts commit 9694046.
Co-authored-by: Matthias Köppe <[email protected]>
Note that the |
I don't see how this is relevant here. I'm trying to build the full sagelib with meson. Just started with a small part to make reviewing easier |
Just a heads up that the monolithic build is going to go away very soon. So it would be unwise to design a new system for the monolithic library. |
Happy to hear!
The top meson.build file is very similar to the top make file, it gives the central starting point to compile the whole sage-library, as well as running tests (and compiling the docs in the future). I kept the requirements of the modularized distributions in mind when I designed the meson files: a modularized distro just needs to provide its own "top-level" meson build file that specifies its name and sets a few variables that control what source files to install and what the required dependencies are. But developing this in detail goes beyond the scope of this PR. |
I've cleanup the PR a bit more. In particular, I've removed all the The installation with build isolation should work now as well. @dimpase @orlitzky @kiwifb please try it, following the instructions in the newly added |
This reverts commit 2a9cd0e.
I'm between hardware right now but I have missed this dearly over the past few weeks. How will I know it's working if it doesn't take me...
eleven and a half minutes to run |
And unconditionally generates conda config files, without checking whether we are on conda, or not. And your macros to handle system Python packages are very slow, as creating venv for every package is not fast... (sorry, I realised I was talking about the standard setup, not about this PR. But bootstrap being slow does not surprise me at all) |
Neither bootstrap nor sage-configure are needed for meson. It generates all the files it needs during build time (like it should). |
Add meson configuration to compile sagelib with meson. Basic developer docs are added as well (meant as background info, not real installation instructions and thus under "developer").
📝 Checklist
⌛ Dependencies