Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented .ramified_places and modified further methods to extend quaternion algebra functionality to number fields #37173

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open
Changes from 20 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
32bcda3
Implemented `.ramified_places` to extend quaternion algebra functiona…
S17A05 Jan 27, 2024
97f1257
Fixed lint issues and refernce formatting
S17A05 Jan 27, 2024
0bb5cfe
Fixed typo and corrected/modified docstrings
S17A05 Jan 27, 2024
2de9c56
Merge branch 'develop' into ramified_places
S17A05 Feb 2, 2024
6e95539
Moved code in `.is_isomorphic`, edited some docstrings
S17A05 Feb 2, 2024
5564841
Merge branch 'develop' into ramified_places
S17A05 Feb 14, 2024
f5fb53b
Merge branch 'develop' into ramified_places
S17A05 Feb 27, 2024
ee88179
Merge branch 'develop' into ramified_places
S17A05 Mar 3, 2024
796cd1d
Merge branch 'develop' into ramified_places
S17A05 Mar 6, 2024
4032e43
Adapted `.ramified_places` slightly, removed docstring modifications
S17A05 Mar 6, 2024
89dae3f
Fixed LINT
S17A05 Mar 6, 2024
deb764e
Small rewrite of `.is_totally_definite()`
S17A05 Mar 8, 2024
ad7d628
Cleaned up some code
S17A05 Mar 8, 2024
d5aa7dd
Merge branch 'develop' into ramified_places
S17A05 Mar 20, 2024
a2c8564
Small doctest fix
S17A05 Mar 25, 2024
914d1b8
Error type correction
S17A05 Mar 25, 2024
dd14d1e
Merge branch 'develop' into ramified_places
S17A05 Mar 26, 2024
9c324bf
Remove redundant copy of `.is_definite()`
S17A05 Mar 26, 2024
15f8fa5
Some doctest refactoring
S17A05 Mar 26, 2024
d09005c
More small refactoring
S17A05 Mar 26, 2024
12f44a3
Implemented reviewer feedback
S17A05 Mar 28, 2024
aec3534
Small docstring modifications
S17A05 Mar 28, 2024
c0b8a65
Corrected `.is_totally_definite()`, moved .. NOTE
S17A05 Mar 28, 2024
da2a805
Added missing type descriptor for `inf` argument
S17A05 Mar 29, 2024
74c1c4d
Implemented reviewer feedback
S17A05 Apr 6, 2024
6207fc5
Merge branch 'develop' into ramified_places
S17A05 Apr 12, 2024
6426296
Changed number field embedding target to `AA`
S17A05 Apr 13, 2024
227d488
Merge branch 'develop' into ramified_places
S17A05 Jun 25, 2024
187988a
Removed duplicate of `.is_definite()`
S17A05 Jun 25, 2024
e783d8b
Replace instances of `is_RationalField` with according `isinstance`-c…
S17A05 Jun 25, 2024
7c04029
Merge branch 'develop' into ramified_places
S17A05 Oct 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading