Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independence posets #37601

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Mar 12, 2024

this is from #33659, with clean-up.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@tscrim
Copy link
Collaborator

tscrim commented Mar 12, 2024

Still some more cleanup to do (e.g., _inc needs doctests, lots of one-line docstrings needed). I will try to do this soon. Although it seems like there is an additional class to be constructed.

Relevant paper: https://arxiv.org/abs/1805.00815

@fchapoton
Copy link
Contributor Author

yes, absolutely not ready, and parts of that are already in sage, for instance is_trim. I just wanted to start cleaning.

src/sage/combinat/independence_posets.py Outdated Show resolved Hide resolved
src/sage/combinat/independence_posets.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 14, 2024

Documentation preview for this PR (built with commit 8bf6574; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

src/sage/combinat/independence_posets.py Outdated Show resolved Hide resolved
src/sage/combinat/independence_posets.py Outdated Show resolved Hide resolved
@dcoudert
Copy link
Contributor

There is a lint error

@fchapoton
Copy link
Contributor Author

there are still some one-line descriptions missing. Also one may like to have more explicit function names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants