code polishing using list comprehension #38131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 9da8cb2; changes) is ready! 🎉 |
mkoeppe
reviewed
Jun 2, 2024
mkoeppe
reviewed
Jun 2, 2024
mkoeppe
reviewed
Jun 2, 2024
Co-authored-by: Matthias Köppe <[email protected]>
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 3, 2024
simplify code in various places by using more list comprehension, as
suggested by `ruff --select=PERF4`
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#38131
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 4, 2024
simplify code in various places by using more list comprehension, as
suggested by `ruff --select=PERF4`
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#38131
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
simplify code in various places by using more list comprehension, as
suggested by `ruff --select=PERF4`
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#38131
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify code in various places by using more list comprehension, as suggested by
ruff --select=PERF4📝 Checklist