Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partial care for empty lines in pyx in rings ; activate E302 in pyx #38263

Merged
merged 2 commits into from
Jul 24, 2024
Merged

partial care for empty lines in pyx in rings ; activate E302 in pyx #38263

merged 2 commits into from
Jul 24, 2024

Conversation

fchapoton
Copy link
Contributor

this is fixing blank lines issues in pyx files in rings folder ; and activating the check for pycodestyle E302 in all pyx files

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 23, 2024 •
edited
Loading

Documentation preview for this PR (built with commit dd4b51d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert suggested changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

src/sage/rings/polynomial/polynomial_number_field.pyx Outdated Show resolved Hide resolved
@fchapoton
Copy link
Contributor Author

merci pour les relectures !

dcoudert
dcoudert approved these changes Jun 23, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 6f913d4 into sagemath:develop Jul 24, 2024
19 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@fchapoton fchapoton deleted the activation_E302_pyx branch July 27, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
v: minimal
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
4 participants
@fchapoton @dcoudert @vbraun @mkoeppe