Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_NumberFieldElement: Fix deprecation message #38286

Merged
merged 1 commit into from
Jul 24, 2024
Merged

is_NumberFieldElement: Fix deprecation message #38286

merged 1 commit into from
Jul 24, 2024

Conversation

mkoeppe
Copy link

@mkoeppe mkoeppe commented Jun 26, 2024 •
edited
Loading

The current message is referring to a class that does not exist.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 26, 2024
@mkoeppe mkoeppe changed the title is_NumberFieldElement: Fix deprecation message is_NumberFieldElement: Fix deprecation message Jun 26, 2024
@mkoeppe mkoeppe added the t: bug label Jun 26, 2024
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 26, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 0ff30e3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe marked this pull request as ready for review June 27, 2024 00:39
@mkoeppe mkoeppe requested a review from tscrim July 3, 2024 06:08
tscrim
tscrim approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Author

mkoeppe commented Jul 8, 2024

Thanks, Travis.

@mkoeppe mkoeppe removed this from the sage-10.4 milestone Jul 21, 2024
@vbraun vbraun merged commit 69b39f7 into sagemath:develop Jul 24, 2024
30 of 31 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@mkoeppe mkoeppe deleted the is_NumberFieldElement_fix_deprecation branch July 25, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: number fields t: bug t: refactoring v: minimal
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @tscrim @vbraun